Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slashing/jailing naming refactors are needed #706

Closed
Tracked by #713
shaspitz opened this issue Feb 3, 2023 · 1 comment
Closed
Tracked by #713

Slashing/jailing naming refactors are needed #706

shaspitz opened this issue Feb 3, 2023 · 1 comment
Labels
S: Productivity Productivity: Developer tooling, infrastructure improvements enabling future growth type: refactoring Code refactoring type: tech-debt Slows down development in the long run

Comments

@shaspitz
Copy link
Contributor

shaspitz commented Feb 3, 2023 •
edited
Loading

Problem

Last minute changes like #692 have made a lot of the semantics around slashing/jailing outdated. We should revisit these naming semantics once the future plans for slashing, untrusted consumers, etc. are more ironed out.

Closing criteria

Naming semantics around slashing/jailing are properly refactored.

Problem details

  • HandleSlashPacket now only handles downtime packets, and mainly just jails a validator. It could be renamed to HandleDowntimeSlashPacket, JailFromDowntimePacket, etc.. something that can now be more descriptive
  • SlashMeter is really a "jail meter". We're limiting validator jailings over time, not slashing
  • SlashPackets are no longer used to enforce slashing, they're used to either log, or jail. InfractionPacket could be appropriate here
  • These are just examples, there might be more refactors needed
@shaspitz shaspitz added type: tech-debt Slows down development in the long run type: refactoring Code refactoring labels Feb 3, 2023
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Cosmos Hub Feb 3, 2023
@shaspitz shaspitz mentioned this issue Feb 3, 2023
Merged
6 tasks
@mpoke mpoke moved this from 🩹 Triage to 📥 Todo in Cosmos Hub Feb 23, 2023
@mpoke mpoke added this to the ICS v1.0.1 milestone Feb 23, 2023
@mpoke mpoke removed this from the ICS v1.0.1 milestone Mar 5, 2023
@mpoke mpoke added the S: Productivity Productivity: Developer tooling, infrastructure improvements enabling future growth label Sep 13, 2023
@mpoke mpoke mentioned this issue Sep 13, 2023
Closed
@mpoke
Copy link
Contributor

mpoke commented Sep 17, 2024

Closing as the refactor would involve API breaking changes.

@mpoke mpoke closed this as completed Sep 17, 2024
@github-project-automation github-project-automation bot moved this from 📥 F2: Todo to 👍 F4: Assessment in Cosmos Hub Sep 17, 2024
@mpoke mpoke moved this from 👍 F4: Assessment to ✅ Done in Cosmos Hub Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
S: Productivity Productivity: Developer tooling, infrastructure improvements enabling future growth type: refactoring Code refactoring type: tech-debt Slows down development in the long run
Projects
Cosmos Hub
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mpoke @shaspitz