Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e tests: support version specific actions for compatbility tests #2198

Closed
Tracked by #2283
bermuell opened this issue Sep 2, 2024 · 0 comments · Fixed by #2319
Closed
Tracked by #2283

e2e tests: support version specific actions for compatbility tests #2198

bermuell opened this issue Sep 2, 2024 · 0 comments · Fixed by #2319
Assignees
Labels
scope: testing Code review, testing, making sure the code is following the specification.

Comments

@bermuell
Copy link
Contributor

bermuell commented Sep 2, 2024

e2e tests need to support version specific actions

Actions on how to perfrom specific test steps change over ICS versions, especially with Permissionless ICS.
E2E framework needs to be adapted to support compatibility testing when test actions changed accross versions.

Bonus:

  • introduce a waitForTx() util function for e2e test which waits until a given transaction is seen
  • change SpawnTime in all actions to more appropriate e.g. TimeUntilSpawn as it is used as a duration and not a specific point in time
  • ChainIDs are used to map configs to chain identifiers. With permissionless ICS, chains with same ChainID are supported which leads to the situation that the ChainID id will be different than the one in in the configuration related configuration. To be easier to differentiate the two ChainIDs (config, key), the map used for the chain configs should be adapted to use a different type for the key.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: testing Code review, testing, making sure the code is following the specification.
Projects
Status: 👍 F4: Assessment
Development

Successfully merging a pull request may close this issue.

1 participant