-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add goreleaser to ICS repo #1035
Labels
S: Productivity
Productivity: Developer tooling, infrastructure improvements enabling future growth
Comments
shaspitz
added
the
status: waiting-triage
This issue/PR has not yet been triaged by the team.
label
Jun 19, 2023
mpoke
removed
the
status: waiting-triage
This issue/PR has not yet been triaged by the team.
label
Jun 20, 2023
mpoke
added
the
S: Productivity
Productivity: Developer tooling, infrastructure improvements enabling future growth
label
Sep 13, 2023
The point of the issue was solved by different means. There's not much goreleaser would help with. Instead of adding goreleaser we added buildtags to the # Makefile
sharedFlags = -X github.com/cosmos/cosmos-sdk/version.Version=$(VERSION) \
-X github.com/cosmos/cosmos-sdk/version.Commit=$(COMMIT)
providerFlags := $(sharedFlags) -X github.com/cosmos/cosmos-sdk/version.AppName=interchain-security-pd -X github.com/cosmos/cosmos-sdk/version.Name=interchain-security-pd
consumerFlags := $(sharedFlags) -X github.com/cosmos/cosmos-sdk/version.AppName=interchain-security-cd -X github.com/cosmos/cosmos-sdk/version.Name=interchain-security-cd
democracyFlags := $(sharedFlags) -X github.com/cosmos/cosmos-sdk/version.AppName=interchain-security-cdd -X github.com/cosmos/cosmos-sdk/version.Name=interchain-security-cdd
standaloneFlags := $(sharedFlags) -X github.com/cosmos/cosmos-sdk/version.AppName=interchain-security-sd -X github.com/cosmos/cosmos-sdk/version.Name=interchain-security-sd
install: go.sum
export GOFLAGS='-buildmode=pie'
export CGO_CPPFLAGS="-D_FORTIFY_SOURCE=2"
export CGO_LDFLAGS="-Wl,-z,relro,-z,now -fstack-protector"
go install -ldflags "$(providerFlags)" ./cmd/interchain-security-pd
go install -ldflags "$(consumerFlags)" ./cmd/interchain-security-cd
go install -ldflags "$(democracyFlags)" ./cmd/interchain-security-cdd
go install -ldflags "$(standaloneFlags)" ./cmd/interchain-security-sd
Now you can do: interchain-security-pd version
# v4.1.0
# or main-<commithash> |
github-project-automation
bot
moved this from 📥 F2: Todo
to 👍 F4: Assessment
in Cosmos Hub
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S: Productivity
Productivity: Developer tooling, infrastructure improvements enabling future growth
Problem
It'd be useful for Hypha if we could populate the following fields for the
version
CLI commandClosing criteria
Implementing goreleaser for this repo could solve the issue. See cosmos/gaia#2549 for gaia
Problem details
The text was updated successfully, but these errors were encountered: