Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "proofs.proto" path #808

Closed
3 tasks
alpe opened this issue Jan 28, 2022 · 2 comments
Closed
3 tasks

Fix "proofs.proto" path #808

alpe opened this issue Jan 28, 2022 · 2 comments

Comments

@alpe
Copy link
Contributor

alpe commented Jan 28, 2022

Summary

The proofs.proto file is in the /third_party/proto root folder while it was usually in /third_party/proto/confio.
I modified the project proto files to be consistent but it would be more convenient to have common a standard within all cosmos projects.

The SDK uses the buf schema registry now: cosmos/cosmos-sdk#10669
I have opened cosmos/ics23#67 to support this.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@alpe
Copy link
Contributor Author

alpe commented May 9, 2022

Same issue with v3

@colin-axner colin-axner mentioned this issue May 10, 2022
Closed
3 tasks
@damiannolan
Copy link
Member

closed by #2705

Updating ics23 to use BSR can be tracked separately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
ibc-go
Status: Done 🥳
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alpe @damiannolan