Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No type registered for ibc.core.client.v1.ClientUpdateProposal #3539

Closed
3 tasks
ryanchristo opened this issue May 1, 2023 · 4 comments
Closed
3 tasks

No type registered for ibc.core.client.v1.ClientUpdateProposal #3539

ryanchristo opened this issue May 1, 2023 · 4 comments

Comments

@ryanchristo
Copy link

Summary of Bug

Ref: regen-network/regen-ledger#1895

A message-based governance proposal with type /ibc.core.client.v1.ClientUpdateProposal produces the following error:

Error: no concrete type registered for type URL /ibc.core.client.v1.ClientUpdateProposal against interface *types.Msg

Expected Behaviour

Submitting a message-based governance proposal with type /ibc.core.client.v1.ClientUpdateProposal produces no error.

Version

v5.2.0

Steps to Reproduce

  1. start simapp using version v5.2.0
  2. create proposal json
nano proposal.json

...

{
  "messages": [
    {
      "@type": "/ibc.core.client.v1.ClientUpdateProposal",
      "title": "Update IBC Client",
      "description": "Update IBC Client",
      "subject_client_id": "07-tendermint-100",
      "substitute_client_id": "07-tendermint-116"
    }
  ],
  "metadata": "",
  "deposit": "1stake"
}
  1. submit proposal
./build/simd tx gov submit-proposal proposal.json --from test
  1. confirm error
Error: no concrete type registered for type URL /ibc.core.client.v1.ClientUpdateProposal against interface *types.Msg

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@damiannolan
Copy link
Member

Hey, thanks for opening the issue! I believe #1282 was created for supporting gov v1 msg execution. I think this will likely be completed as part of the next major release ibc-go/v8.

@ryanchristo
Copy link
Author

Just noting here that the documentation is a bit misleading atm. As far as I understand, the non-recommended way of submitting a proposal to update a client (i.e. submit-legacy-proposal) is the only option for a chain running v0.46 with ibc-go v5.x.

https://ibc.cosmos.network/main/ibc/proposals.html#step-2

@crodriguezvega
Copy link
Contributor

As far as I understand, the non-recommended way of submitting a proposal to update a client (i.e. submit-legacy-proposal) is the only option for a chain running v0.46 with ibc-go v5.x.

Yes, I think you're correct and we should then update our docs. Once #1282 is implemented and we can support gov v1 message execution we will update the docs again.

@crodriguezvega
Copy link
Contributor

Closed by #4580

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants