Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write test to test getRangeProof logic #115

Closed
jaekwon opened this issue Oct 19, 2018 · 0 comments
Closed

Write test to test getRangeProof logic #115

jaekwon opened this issue Oct 19, 2018 · 0 comments
Assignees
@jaekwon

Comments

@jaekwon
Copy link
Contributor

jaekwon commented Oct 19, 2018

https://github.com/tendermint/iavl/pull/105/files#r215906281

I scanned the history and it looks like pathCount = -1 is correct -- I think the pathCount-- was introduced as a bug; but as Ismael points out, the tests should have caught it but didn't.

We should write tests that fail when pathCount-- but passes with pathCount = -1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaekwon jaekwon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jaekwon @tac0turtle