Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilize or remove signed messages within validator claims #148

Closed
okwme opened this issue Feb 27, 2020 · 0 comments
Closed

Utilize or remove signed messages within validator claims #148

okwme opened this issue Feb 27, 2020 · 0 comments

Comments

@okwme
Copy link
Contributor

okwme commented Feb 27, 2020

Currently in Oracle.sol within the newOracleClaim() function, the signature from the validator is verified but the message itself is signed by the same address already. This is redundant verification. As @denalimarsh pointed out in #140 :

The signature is used to validate that the validator signed a message containing the prophecy's information, but since the message isn't compared to the prophecy's actual information the check looks to be redundant. Therefore the message and signature could be removed entirely, with the address alone denoting that this validator agrees with the prophecy claim information in event LogNewProphecyClaim. However, retaining the message/signature and parameterizing the validator's address would allow for the aggregation and submission of oracle claims by another party (such as the relayer or the intended recipient).

This issue is to discuss what would be needed to utilize just the signature and whether the benefit of using a third party to execute these transactions on behalf of the validator is worth doing so. The biggest benefit i see is the responsibility of gas payment becomes that of the message executor and not of the validator. This would prevent spamming validators, which would be possible when they were responsible for footing the bill.

Are there other reasons for or against it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants