Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FTBFS: update against cosmos-sdk v0.34.4-0.20200409184808-709d96a6f4c4 #352

Closed
4 tasks
alessio opened this issue Apr 9, 2020 · 8 comments
Closed
4 tasks
Assignees
Labels
scope: build Changes, features and bugs related the build process.

Comments

@alessio
Copy link
Contributor

alessio commented Apr 9, 2020

gaia FTBFS when compiled against github.com/cosmos/cosmos-sdk rev v0.34.4-0.20200409184808-709d96a6f4c4 - related to cosmos/cosmos-sdk#5966

An excerpt of the build log follows:

alessio@bangalter:~/work/gaia$ make install
go install -mod=readonly -tags "netgo ledger" -ldflags '-X github.com/cosmos/cosmos-sdk/version.Name=gaia -X github.com/cosmos/cosmos-sdk/version.ServerName=gaiad -X github.com/cosmos/cosmos-sdk/version.ClientName=gaiacli -X github.com/cosmos/cosmos-sdk/version.Version=0.0.0-172-g2bff973 -X github.com/cosmos/cosmos-sdk/version.Commit=2bff973c92f3529f942f790ec44e83c65f83fc4e -X "github.com/cosmos/cosmos-sdk/version.BuildTags=netgo,ledger"' -trimpath ./cmd/gaiad
# github.com/cosmos/gaia/app
app/app.go:271:40: not enough arguments in call to auth.NewAnteHandler
	have ("github.com/cosmos/cosmos-sdk/x/auth/keeper".AccountKeeper, "github.com/cosmos/cosmos-sdk/x/supply/keeper".Keeper, func("github.com/cosmos/cosmos-sdk/store/types".GasMeter, []byte, crypto.PubKey, "github.com/cosmos/cosmos-sdk/x/auth/types".Params) error)
	want ("github.com/cosmos/cosmos-sdk/x/auth/keeper".AccountKeeper, "github.com/cosmos/cosmos-sdk/x/auth/types".SupplyKeeper, "github.com/cosmos/cosmos-sdk/x/ibc/keeper".Keeper, func("github.com/cosmos/cosmos-sdk/store/types".GasMeter, []byte, crypto.PubKey, "github.com/cosmos/cosmos-sdk/x/auth/types".Params) error)
Makefile:94: recipe for target 'install' failed
make: *** [install] Error 2

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@alessio
Copy link
Contributor Author

alessio commented Apr 11, 2020

@jackzampolin can you provide a justification when you close an issue please? Thanks!

@alessio
Copy link
Contributor Author

alessio commented Apr 11, 2020

Reopening as this still stands. We shall close it when it's resolved.

@alessio alessio reopened this Apr 11, 2020
@tac0turtle
Copy link
Member

tac0turtle commented Apr 23, 2020

If we update to master of the sdk this should not be present

@alessio have you tested with master lately?

@tac0turtle tac0turtle added the scope: build Changes, features and bugs related the build process. label Apr 23, 2020
@alexanderbez
Copy link
Contributor

WTF is FTBFS?

1 similar comment
@alexanderbez
Copy link
Contributor

WTF is FTBFS?

@alessio
Copy link
Contributor Author

alessio commented Apr 23, 2020

WTF is FTBFS?

Fail To Build From Source

@alessio have you tested with master lately?

This can be closed once ibc-alpha is merged in

@alexanderbez
Copy link
Contributor

Can we just close this issue? ibc-alpha will have the latest SDK head commit.

@alessio
Copy link
Contributor Author

alessio commented Apr 23, 2020

Can we just close this issue? ibc-alpha will have the latest SDK head commit.

Yep, ibc-alpha is ready. Let's close it. Thanks!

@alessio alessio closed this as completed Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: build Changes, features and bugs related the build process.
Projects
None yet
Development

No branches or pull requests

4 participants