Skip to content

Conversation

@beer-1
Copy link
Contributor

@beer-1 beer-1 commented Oct 31, 2025

Description

Isolate CheckTx and simulation state from DeliverTx commits by loading the last committed snapshot and keeping the simulation context in sync

Closes: #20685 #23891

@beer-1
Copy link
Contributor Author

beer-1 commented Oct 31, 2025

Hey @aljo242, can you check this approach?

Backport PRs: #25530 #25531

I’ve tested the update using these test cases, and it appears to be working well. However, it’s difficult to merge the tests into the main branch since they depend on some changes in the ante module.

@aljo242
Copy link
Contributor

aljo242 commented Oct 31, 2025

@beer-1 could you please re-open these with signed commits?

…oading the last committed snapshot and keeping the simulation context in sync
@beer-1 beer-1 force-pushed the fix/state-pollution branch from b6870ac to 8f8e43a Compare November 1, 2025 00:41
@beer-1
Copy link
Contributor Author

beer-1 commented Nov 1, 2025

@aljo242 changed to use signed commit

@beer-1
Copy link
Contributor Author

beer-1 commented Nov 3, 2025

I fixed the race data write by changing RWMutex to Mutex

aljo242 and others added 4 commits November 4, 2025 13:32
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…osmos#25535)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Alex | Cosmos Labs <[email protected]>
@beer-1
Copy link
Contributor Author

beer-1 commented Nov 4, 2025

@aljo242 introduced a mutex for cms(CacheMultiStore).stores to prevent data races during lazy loading. This issue was mainly observed in concurrent genesis export tests. and succeed to pass tests locally with update.

@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

❌ Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 70.82%. Comparing base (84e841a) to head (cdbbbdc).

Files with missing lines Patch % Lines
baseapp/state/manager.go 90.90% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #25529      +/-   ##
==========================================
+ Coverage   69.99%   70.82%   +0.83%     
==========================================
  Files         827      874      +47     
  Lines       54070    57098    +3028     
==========================================
+ Hits        37844    40440    +2596     
- Misses      16226    16658     +432     
Files with missing lines Coverage Δ
store/cachemulti/store.go 60.97% <100.00%> (ø)
baseapp/state/manager.go 83.07% <90.90%> (+0.93%) ⬆️

... and 58 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: simulation is async from the commit and checkTx, so it should use cms with version

2 participants