-
Notifications
You must be signed in to change notification settings - Fork 4.1k
fix: isolate CheckTx and simulation state from DeliverTx commits #25529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hey @aljo242, can you check this approach? I’ve tested the update using these test cases, and it appears to be working well. However, it’s difficult to merge the tests into the main branch since they depend on some changes in the ante module. |
|
@beer-1 could you please re-open these with signed commits? |
…oading the last committed snapshot and keeping the simulation context in sync
b6870ac to
8f8e43a
Compare
|
@aljo242 changed to use signed commit |
|
I fixed the race data write by changing RWMutex to Mutex |
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…osmos#25535) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alex | Cosmos Labs <[email protected]>
398b597 to
5f2df19
Compare
|
@aljo242 introduced a mutex for cms(CacheMultiStore).stores to prevent data races during lazy loading. This issue was mainly observed in concurrent genesis export tests. and succeed to pass tests locally with update. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25529 +/- ##
==========================================
+ Coverage 69.99% 70.82% +0.83%
==========================================
Files 827 874 +47
Lines 54070 57098 +3028
==========================================
+ Hits 37844 40440 +2596
- Misses 16226 16658 +432
🚀 New features to boost your workflow:
|
Description
Isolate CheckTx and simulation state from DeliverTx commits by loading the last committed snapshot and keeping the simulation context in sync
Closes: #20685 #23891