gRPC GetTxByHash should return transaction metadata

[jkilpatr]

Summary

The current implementation of GetTxByHash returns a TX object, which contains no metadata whatsoever about the tx's status on the chain. Is it in the chain? How much gas did it use? What height did it get in at?

All of these questions could be answered by the amino endpoint, currently none of them can be found in the gRPC response.

Problem Definition

Most users who are requesting a transaction by hash do not only want the full transaction but also wish to know it's status on the chain. This is why the same info in amino and on eth returns this info in addition to just the transaction data itself.

Proposal

The endpoint should return a new struct TxInfo (or whatever name best fits convention) that contains metadata about the transaction status and the Tx object itself as a field.

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[amaury1093]

We also noticed this, and quickly fixed it. It now returns a TxResponse too:

cosmos-sdk/proto/cosmos/tx/v1beta1/service.proto

Lines 71 to 77 in a51eac4

	// GetTxResponse is the response type for the Service.GetTx method.
	message GetTxResponse {
	// tx is the queried transaction.
	cosmos.tx.v1beta1.Tx tx = 1;
	// tx_response is the queried TxResponses.
	cosmos.base.abci.v1beta1.TxResponse tx_response = 2;
	}

Does that work for you? (it's not in rc3/rc4 yet though, but will be in stargate)

[jkilpatr]

yes this works just fine. I thought for sure I was searching on master but I must have had the rc4 tag up, thanks!