Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change blacklist naming #6447

Closed
4 tasks
colin-axner opened this issue Jun 16, 2020 · 2 comments · Fixed by #6455
Closed
4 tasks

Change blacklist naming #6447

colin-axner opened this issue Jun 16, 2020 · 2 comments · Fixed by #6455

Comments

@colin-axner
Copy link
Contributor

Summary

Change blacklist to a neutral term that suggests its function without further reading.

Problem Definition

The function of blacklisted accounts was added as a fix to prevent module supply invariants from breaking during the lifetime of the chain. While the term does have popular usage in the computer science world, it is not neutral ("whitelist/blacklist") and can have negative connotations whether or not it was originally intended to. Furthermore, I find the usage vague in reference to the exact restrictions placed on a module account address.

Proposal

I don't have a replacement term in mind, but it should reference the specific characteristic that module accounts cannot be sent to. Maybe something like DisableRecvList/DenyRecvList or CannotSendToList


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@alexanderbez
Copy link
Contributor

You have my full support in this regard. Should be a trivial thing to tackle 👍

@aaronc
Copy link
Member

aaronc commented Jun 16, 2020

See golang/go@608cdca and golang/go@2cd2ff6 for details on the naming golang has adopted. We should likely follow these conventions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants