Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Acknowledgements in ICS 20 #5923

Closed
cwgoes opened this issue Apr 3, 2020 · 3 comments · Fixed by #5984
Closed

Acknowledgements in ICS 20 #5923

cwgoes opened this issue Apr 3, 2020 · 3 comments · Fixed by #5984
Assignees
@AdityaSripal
Milestone
IBC GoZ Readiness

Comments

@cwgoes
Copy link
Contributor

cwgoes commented Apr 3, 2020

Implement acknowledgements of success/failure and refunds per cosmos/ibc#375.
@cwgoes cwgoes added the x/ibc label Apr 3, 2020
@cwgoes cwgoes added this to the IBC 1.0 milestone Apr 3, 2020
@cwgoes cwgoes mentioned this issue Apr 3, 2020
Closed
@cwgoes
Copy link
Contributor Author

cwgoes commented Apr 3, 2020

This is blocked on #5888.

@cwgoes cwgoes added the S:blocked Status: Blocked label Apr 3, 2020
@cwgoes cwgoes modified the milestones: IBC 1.0, IBC GoZ Readiness Apr 3, 2020
@AdityaSripal
Copy link
Member

I'll work on this once #5888 is merged

@AdityaSripal AdityaSripal self-assigned this Apr 5, 2020
@cwgoes
Copy link
Contributor Author

cwgoes commented Apr 6, 2020

Changes required:

  • Write acknowledgements of success/failure on receipt of packets & transfer execution
  • Handle acknowledgements of failure on the source chain by refunding the tokens

Acknowledgements of failure should include an informative error code or message.

@cwgoes cwgoes removed the S:blocked Status: Blocked label Apr 7, 2020
@AdityaSripal AdityaSripal mentioned this issue Apr 10, 2020
Merged
11 tasks
@mergify mergify bot closed this as completed in #5984 Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdityaSripal AdityaSripal

Labels
None yet
Projects
None yet
Milestone
IBC GoZ Readiness
Development

Successfully merging a pull request may close this issue.

Implement ICS-20 Callbacks cosmos/cosmos-sdk
2 participants
@AdityaSripal @cwgoes