Problem with null genutil when exporting state

[toml01]

Summary of Bug

Exporting state:

enigmad export --for-zero-height --height=40000 > a.json

Then when validating, I'm getting the following error:

$ enigmad validate-genesis a.json 
validating genesis file at a.json
ERROR: error validating genesis file a.json: failed to unmarshal genutil genesis state: UnmarshalJSON cannot decode empty bytes

Then looked in a.json (the file exported), and noticed:

"genutil":null

If I'm not mistaken, it should be "genutil": {} right?

The full exported state:
https://gist.github.com/toml01/3711dfa85b26d37916080040b67ef827

This bug looks similar to #5086 , should've been fixed in 0.38 I believe?

Version

v0.38.1

Steps to Reproduce

Run a chain for some time, then just export the state with --for-zero-height and --height and check for genutil

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[alexanderbez]

Indeed, it should be [], but this has already been fixed. What version are you using?

[assafmo]

v0.38.1

[alexanderbez]

Interesting. The DefaultGenesisState for x/genutil should populate with [].

[toml01]

If I manually replace the null with [] I get:

➜  ~ enigmad validate-genesis a.json 
validating genesis file at a.json
ERROR: error validating genesis file a.json: failed to unmarshal genutil genesis state: json: cannot unmarshal array into Go value of type map[string]json.RawMessage

However, when I put {} it works.

➜  ~ enigmad validate-genesis a.json 
validating genesis file at a.json
File at genesis-enigma-testnet-1-3.json is a valid genesis file

[alexanderbez]

Sorry, I should've clarified. This is what I'd expect for default/empty state:

"genutil": {
  "gentxs": []
}

Does that not work?

[alexanderbez]

However, upon export, it's still null so this is indeed a bug:

// ExportGenesis returns the exported genesis state as raw bytes for the genutil
// module.
func (am AppModule) ExportGenesis(_ sdk.Context, _ codec.JSONMarshaler) json.RawMessage {
	return nil
}

This needs to return the state.

[toml01]

Yes what you suggested:

"genutil": {
  "gentxs": []
}

works too.

[alexanderbez]

Thanks for the report @toml01. Easy fix, sorry for this.

[toml01]

Cool, I can open a quick PR for this

[alexanderbez]

Yes, please!

[toml01]

Thanks @alexanderbez ! Didn't have a chance to look at it yet, sorry.