-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review work on on ADR 15 #5546
Comments
Sequence increasing is now happening inside |
It should be called by the receiving side of the connection(in the ICS20 handler), will check it once more WriteAcknowledgement should be called by the receipt handler |
That seems like a mistake.... can be fixed by using a cachecontext inside the antehandler, keep increasing sequence, but not writing back to the underlying store... |
OK, I am not entirely sure what you mean, can you write it in a PR perhaps? (ditto for the above) |
what is the receipt handler? |
in the case of multiple packet executions, are all of them atomic, i.e should we revert any change if one of those executions fail? |
For now, I think we should maintain the atomicity semantics of multi-Msg transactions, but subject to separate acknowledgement/failure handling as defined by the IBC spec (so a "ack of failure" would cause remaining packets to be processed, but an invalid sequence would cause remaining packets to fail & all state changes to be reverted). Does that make sense? |
I don't think there are any remaining actionables here. @mossid if there are please open issues. |
From this comment onwards - #5401 (comment)
The text was updated successfully, but these errors were encountered: