Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split out interfaces for acknowledgements #5509

Closed
cwgoes opened this issue Jan 10, 2020 · 4 comments
Closed

Split out interfaces for acknowledgements #5509

cwgoes opened this issue Jan 10, 2020 · 4 comments
Assignees
@cwgoes
Milestone
IBC 1.0 [Implemen...

Comments

@cwgoes
Copy link
Contributor

cwgoes commented Jan 10, 2020

Acknowledgements should not fulfil PacketDataI, e.g. they don't have a timeout.

We need another interface.

Blocks 1.0.
@cwgoes cwgoes added the x/ibc label Jan 10, 2020
@cwgoes cwgoes mentioned this issue Jan 10, 2020
Merged
11 tasks
@fedekunze fedekunze added this to the IBC Implementation milestone Jan 21, 2020
@mossid
Copy link
Contributor

mossid commented Jan 29, 2020

Is there any other difference between PacketDataI / AckDataI except for the timeout?

@cwgoes
Copy link
Contributor Author

cwgoes commented Feb 3, 2020

Is there any other difference between PacketDataI / AckDataI except for the timeout?

Acknowledgements are just data (bytes) - they don't have a timeout, a validation function, or a type.

@cwgoes cwgoes self-assigned this Feb 3, 2020
This was referenced Feb 3, 2020
Merged
Merged
@cwgoes
Copy link
Contributor Author

cwgoes commented Feb 3, 2020

In #5603 I have created a separate PacketAcknowledgementI interface with only GetBytes().

@fedekunze
Copy link
Collaborator

closed via #5577

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cwgoes cwgoes

Labels
None yet
Projects
None yet
Milestone
IBC 1.0 [Implementation]
Development

No branches or pull requests
3 participants
@mossid @cwgoes @fedekunze