Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Fix gaiad export #3148

Merged
merged 2 commits into from
Dec 18, 2018
Merged

R4R: Fix gaiad export #3148

merged 2 commits into from
Dec 18, 2018

Conversation

cwgoes
Copy link
Contributor

@cwgoes cwgoes commented Dec 18, 2018

Closes #3147

We should figure out why this still worked in the testing CI script. Anyway, not a hard fix.


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@cwgoes cwgoes added C:CLI tooling dev tooling within the sdk labels Dec 18, 2018
@zmanian
Copy link
Member

zmanian commented Dec 18, 2018

Works on game_of_stakes

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testedACK.

@codecov
Copy link

codecov bot commented Dec 18, 2018

Codecov Report

Merging #3148 into develop will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           develop    #3148   +/-   ##
========================================
  Coverage    55.03%   55.03%           
========================================
  Files          133      133           
  Lines         9434     9434           
========================================
  Hits          5192     5192           
  Misses        3925     3925           
  Partials       317      317

@cwgoes cwgoes merged commit 371c7ad into develop Dec 18, 2018
cwgoes added a commit that referenced this pull request Dec 19, 2018
* Add boolean for LoadLatestVersion
* Update PENDING.md
@alessio alessio deleted the cwgoes/fix-gaiad-export branch December 20, 2018 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:CLI tooling dev tooling within the sdk
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic on gaiad export --height
4 participants