Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add truncate decimal functionality #2378

Closed
rigelrozanski opened this issue Sep 22, 2018 · 0 comments
Closed

Add truncate decimal functionality #2378

rigelrozanski opened this issue Sep 22, 2018 · 0 comments

Comments

@rigelrozanski
Copy link
Contributor

We need the capability for our decimal library to be truncated (in addition to being rounded which already exists) - this will be used by distribution

chillyvee pushed a commit to chillyvee/cosmos-sdk that referenced this issue Mar 1, 2024
* - Update doc to follow Go conventions
- Improve code readability

* update params

* rebase and fix nits

* add GetMinGasPrice UT

* remove unused feetestsuite

* rebase

* update doc

* nits

* nits

* refactor fee tests setup

* remove comments

* Update x/globalfee/ante/antetest/fee_test.go

Co-authored-by: yaruwangway <[email protected]>

* Update x/globalfee/ante/antetest/fee_test.go

Co-authored-by: yaruwangway <[email protected]>

* Update x/globalfee/ante/antetest/fee_test.go

Co-authored-by: yaruwangway <[email protected]>

* Update x/globalfee/ante/antetest/fee_test.go

Co-authored-by: yaruwangway <[email protected]>

* Update x/globalfee/ante/antetest/fee_test.go

Co-authored-by: yaruwangway <[email protected]>

* Update x/globalfee/ante/antetest/fee_test.go

* fix GetMinGasPrice to not return nil coins

* min gas price zero coins edge cases

* min gas price zero coins edge cases

* remove debug logs

* udpate comments

* udpate comments

* add comment

* Update x/globalfee/types/params.go

Co-authored-by: yaruwangway <[email protected]>

* Update x/globalfee/types/params.go

Co-authored-by: yaruwangway <[email protected]>

* fix: lint

Signed-off-by: Yaru Wang <[email protected]>

* refactor: global fee zero coins

* refactor: add splitGlobalFees()

* fix: globalfee antehandler

* fix: add test helper func

* update according to PR comments

* test: add test for splitGlobalFees()

* code improvement

* refactor: globalfee antehandler

* refactor: bypass logic

* refactor: fee check logic

* fix: lint

* fix: return err when required fees are not set up

* chore: clean comments

* Sainoe/globalfee coins (cosmos#2378)

* chore(deps): bump github.com/golangci/golangci-lint (cosmos#2319)

Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.51.2 to 1.52.1.
- [Release notes](https://github.com/golangci/golangci-lint/releases)
- [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md)
- [Commits](golangci/golangci-lint@v1.51.2...v1.52.1)

---
updated-dependencies:
- dependency-name: github.com/golangci/golangci-lint
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Marius Poke <[email protected]>
Co-authored-by: Milan Mulji <[email protected]>

* chore(deps): bump github.com/docker/docker (cosmos#2365)

Bumps [github.com/docker/docker](https://github.com/docker/docker) from 20.10.19+incompatible to 20.10.24+incompatible.
- [Release notes](https://github.com/docker/docker/releases)
- [Commits](moby/moby@v20.10.19...v20.10.24)

---
updated-dependencies:
- dependency-name: github.com/docker/docker
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Removed trust node in docs (cosmos#2359)

* update ditrosless image url in Dockerfiles

* nits

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Marius Poke <[email protected]>
Co-authored-by: Milan Mulji <[email protected]>

* fix nits

---------

Signed-off-by: Yaru Wang <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Simon Noetzlin <[email protected]>
Co-authored-by: MSalopek <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Marius Poke <[email protected]>
Co-authored-by: Milan Mulji <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant