Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth: Move stdsignmsg to txbuilder, add tests #2377

Merged
merged 2 commits into from
Sep 26, 2018
Merged

Conversation

ValarDragon
Copy link
Contributor

This is done because stdsignmsg is only used within the txbuilder. It explicitly states only for use within the CLI, hence it belongs in one of the client packages.

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work. - sufficiently simple imo
  • Wrote tests
  • Updated relevant documentation (docs/) - anything I should be updating?
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 👍

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, thanks for the testcases 🎉

@codecov
Copy link

codecov bot commented Sep 26, 2018

Codecov Report

❗ No coverage uploaded for pull request base (develop@145e06b). Click here to learn what that means.
The diff coverage is 22.22%.

@@            Coverage Diff             @@
##             develop    #2377   +/-   ##
==========================================
  Coverage           ?   63.75%           
==========================================
  Files              ?      141           
  Lines              ?     8738           
  Branches           ?        0           
==========================================
  Hits               ?     5571           
  Misses             ?     2790           
  Partials           ?      377

@cwgoes cwgoes merged commit e6a8b22 into develop Sep 26, 2018
@cwgoes cwgoes deleted the dev/refactor_stdsignmsg branch September 26, 2018 13:39
chillyvee pushed a commit to chillyvee/cosmos-sdk that referenced this pull request Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants