Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Misuse of request with OE #19197

Closed
1 task done
alexanderbez opened this issue Jan 23, 2024 · 0 comments · Fixed by #19198
Closed
1 task done

[Bug]: Misuse of request with OE #19197

alexanderbez opened this issue Jan 23, 2024 · 0 comments · Fixed by #19198
Labels
T:Bug

Comments

@alexanderbez
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

The OE Execute function uses req within the goroutine here. Since req is a pointer provided by ProcessProposal, it may be possible to log incorrect information if the pointer is mutated. It would be safer to use oe.request.Height and oe.request.Hash instead of req.Height and req.Hash.

Cosmos SDK Version

v0.47.x, v0.50.x

How to reproduce?

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T:Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(OE): Remove usage of pointer in logs cosmos/cosmos-sdk
1 participant
@alexanderbez