Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logging #14967

Closed
6 tasks done
tac0turtle opened this issue Feb 9, 2023 · 1 comment · Fixed by #15212
Closed
6 tasks done

logging #14967

tac0turtle opened this issue Feb 9, 2023 · 1 comment · Fixed by #15212
Assignees

Comments

@tac0turtle
Copy link
Member

tac0turtle commented Feb 9, 2023

Summary

Currently we use comet's interface for logging in the sdk. While this is an okay solution, zero log and other loggers have the opportunity to be typed. Secondly, the comet logger is limiting in what we would like to achieve with logging. For now, we have recreated the same interface to not cause large breaking changes, but once the sdk is migrated to the new interface and its loggers, we should break the interface, remove comet as a dependency and define the interface as we want.

Work Breakdown

  • Introduce logger interface same as comets
  • Introduce noplogger and migrate the repo to use it.
  • Introduce zero logger and migrate the repo to use it
  • Add Filtering to zerolog
  • Break the logger interface to remove comet dep and better fit our needs
  • Create a wrapper logger that can be passed to comet on start.
@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label Feb 9, 2023
@tac0turtle tac0turtle removed the needs-triage Issue that needs to be triaged label Feb 9, 2023
@julienrbrt
Copy link
Member

relevant discussion: #14955 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants