config fix

[tac0turtle]

Summary

When starting up your node with a new binary many times there is an existing config, but the new config doesn't have the new config variables that may have been added. Something like this was written for tendermint and we could easily port it over.

Proposal

provide a way to fix existing configs with new variables.

TM implementation:

• https://github.com/tendermint/tendermint/blob/v0.36.x/scripts/confix/confix.go
• https://github.com/tendermint/tendermint/blob/v0.36.x/internal/libs/confix/confix.go
• https://github.com/tendermint/tendermint/blob/5013bc3f4a6d64dcc2bf02ccc002ebc9881c62e4/docs/rfc/rfc-019-config-version.md

[alexanderbez]

Why not just do a diff and print a warning with missing keys?

[tac0turtle]

why not just do it for the user? less manual labor for the node operator means a happier node operator

[alexanderbez]

Do what for the user? The user still has to manually add the values they want. Only thing we can do is let them know what's missing.

Otherwise, you can just bypass this altogether and populate missing fields with the default values.

[tac0turtle]

on startup of the node ideally we check the config, if all values + new ones are there, we do nothing, if not we grab the defaults and write them to the config. This way users don't have to copy paste to add them. if we output in the console what's missing we can do the next step to auto add them

[alexanderbez]

... if all values + new ones are there, we do nothing, if not we grab the defaults and write them to the config

Yes, this makes sense to me. This is what I was alluding to. But there's no need for a script or command to do this (which is what TM seems to do?) -- we can do it automatically on startup.