-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/gov min proposer deposit #12450
Comments
@p0mvn already did this phenomenal work for Osmosis' fork of the SDK here: osmosis-labs#296 -- we should just simply upstream this to the core SDK repo. |
If we implement it in a non API breaking way then we can backport that feature to 0.46. |
I don't think that's really possible. I think we should just upstream the Osmosis feature. |
I have already started moving the change here. The change breaks the gov proto and requires parameter migrations. However, I don't think there are any other API breaks. One other caveat with the work in osmosis-labs#296 is that it does not burn the deposit unless it is vetoed or does not move to the voting period. This is contrary to the conclusion in #11130 (reply in thread) In Osmosis, we estimated that it would be too costly to spam a lot of proposals and then fully fulfill the deposit. However, I can extend osmosis-labs#296 to fulfill the conclusions from #11130 (reply in thread) if that is still desired? |
Yes, this is fine and expected :)
This is a great question. I would lean towards the solution/approach Osmosis took, but I'd like to hear input from others. @hxrts @marbar3778 @AmauryM |
I see - the discussion and the decision about burning the deposit are related to the proposal withdrawal, not min proposer deposit. Then, #12771 should match the requirements. Thanks @robert-zaremba |
Yes, thanks @p0mvn |
Summary
Add x/gov
min-proposer-deposit
param to require a deposit from proposer when adding proposal.Ref: #11130 (reply in thread) by @anilcse
Problem Definition
Today anyone can create proposals for free (only tx cost) and spam the the gov view. These proposals won't advance to voting phase, unless they will got enough deposit, but will spam the views.
Proposal
Require additional, small deposit from the proposer when submitting a gov proposal.
For Admin Use
The text was updated successfully, but these errors were encountered: