Skip to content

Commit e2d6cbd

Browse files
chore: changelog update (#12859)
* updates * updates * updates Co-authored-by: Marko <[email protected]>
1 parent 1cab2bc commit e2d6cbd

File tree

3 files changed

+8
-4
lines changed

3 files changed

+8
-4
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
4545

4646
### Improvements
4747

48+
* (events) [#12850](https://github.com/cosmos/cosmos-sdk/pull/12850) Add a new `fee_payer` attribute to the `tx` event that is emitted from the `DeductFeeDecorator` AnteHandler decorator.
4849
* (ci) [#12854](https://github.com/cosmos/cosmos-sdk/pull/12854) Use ghcr.io to host the proto builder image. Update proto builder image to go 1.19
4950
* (x/bank) [#12706](https://github.com/cosmos/cosmos-sdk/pull/12706) Added the `chain-id` flag to the `AddTxFlagsToCmd` API. There is no longer a need to explicitly register this flag on commands whens `AddTxFlagsToCmd` is already called.
5051
* [#12791](https://github.com/cosmos/cosmos-sdk/pull/12791) Bump the math library used in the sdk and replace old usages of sdk.*

x/auth/ante/fee.go

+5-2
Original file line numberDiff line numberDiff line change
@@ -110,8 +110,11 @@ func (dfd DeductFeeDecorator) checkDeductFee(ctx sdk.Context, sdkTx sdk.Tx, fee
110110
}
111111

112112
events := sdk.Events{
113-
sdk.NewEvent(sdk.EventTypeTx, sdk.NewAttribute(sdk.AttributeKeyFee, fee.String())),
114-
sdk.NewEvent(sdk.EventTypeTx, sdk.NewAttribute(sdk.AttributeKeyFeePayer, deductFeesFrom.String())),
113+
sdk.NewEvent(
114+
sdk.EventTypeTx,
115+
sdk.NewAttribute(sdk.AttributeKeyFee, fee.String()),
116+
sdk.NewAttribute(sdk.AttributeKeyFeePayer, deductFeesFrom.String()),
117+
),
115118
}
116119
ctx.EventManager().EmitEvents(events)
117120

x/auth/tx/service_test.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ func (s IntegrationTestSuite) TestSimulateTx_GRPC() {
225225
// - tx.* events: tx.fee, tx.acc_seq, tx.signature
226226
// - Sending Amount to recipient: coin_spent, coin_received, transfer and message.sender=<val1>
227227
// - Msg events: message.module=bank and message.action=/cosmos.bank.v1beta1.MsgSend
228-
s.Require().Equal(len(res.GetResult().GetEvents()), 14) // 1 coin recv 1 coin spent, 1 transfer, 3 messages.
228+
s.Require().Equal(len(res.GetResult().GetEvents()), 13) // 1 coin recv 1 coin spent, 1 transfer, 3 messages.
229229
s.Require().True(res.GetGasInfo().GetGasUsed() > 0) // Gas used sometimes change, just check it's not empty.
230230
}
231231
})
@@ -267,7 +267,7 @@ func (s IntegrationTestSuite) TestSimulateTx_GRPCGateway() {
267267
s.Require().NoError(err)
268268
// Check the result and gas used are correct.
269269
s.Require().Len(result.GetResult().MsgResponses, 1)
270-
s.Require().Equal(len(result.GetResult().GetEvents()), 14) // See TestSimulateTx_GRPC for the 13 events.
270+
s.Require().Equal(len(result.GetResult().GetEvents()), 13) // See TestSimulateTx_GRPC for the 13 events.
271271
s.Require().True(result.GetGasInfo().GetGasUsed() > 0) // Gas used sometimes change, jus
272272
}
273273
})

0 commit comments

Comments
 (0)