From e17792b5b81b0319ab2ed89384941a73d293ab41 Mon Sep 17 00:00:00 2001 From: Roy Crihfield Date: Mon, 23 Aug 2021 15:19:26 +0800 Subject: [PATCH] clone is not needed here redundant since dbWriter uses a clone --- db/memdb/db.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/db/memdb/db.go b/db/memdb/db.go index 1485aae1dcba..be5cb83079c4 100644 --- a/db/memdb/db.go +++ b/db/memdb/db.go @@ -108,6 +108,7 @@ func (db *MemDB) ReadWriter() dbm.DBReadWriter { db.mtx.RLock() defer db.mtx.RUnlock() atomic.AddInt32(&db.openWriters, 1) + // Clone creates a copy-on-write extension of the current tree return &dbWriter{db.newTxn(db.btree.Clone())} } @@ -124,8 +125,6 @@ func (db *MemDB) save(target uint64) (uint64, error) { return 0, err } db.saved[target] = db.btree - // BTree's Clone() makes a CoW extension of the current tree - db.btree = db.btree.Clone() db.vmgr = newVmgr return target, nil }