address review comments

Author: arijitAD

x/mint/abci.go

@@ -20,11 +20,7 @@ func BeginBlocker(ctx sdk.Context, k keeper.Keeper, ic types.InflationCalculatio
 	// recalculate inflation rate
 	totalStakingSupply := k.StakingTokenSupply(ctx)
 	bondedRatio := k.BondedRatio(ctx)
-	if ic == nil {
-		minter.Inflation = minter.NextInflationRate(params, bondedRatio)
-	} else {
-		minter.Inflation = ic(ctx, minter, params, bondedRatio)
-	}
+	minter.Inflation = ic(ctx, minter, params, bondedRatio)
 	minter.AnnualProvisions = minter.NextAnnualProvisions(params, totalStakingSupply)
 	k.SetMinter(ctx, minter)
 

x/mint/module.go

@@ -97,6 +97,9 @@ type AppModule struct {
 
 // NewAppModule creates a new AppModule object
 func NewAppModule(cdc codec.Codec, keeper keeper.Keeper, ak types.AccountKeeper, ic types.InflationCalculationFn) AppModule {
+	if ic == nil {
+		ic = types.DefaultInflationCalculationFn
+	}
 	return AppModule{
 		AppModuleBasic:      AppModuleBasic{cdc: cdc},
 		keeper:              keeper,

x/mint/types/genesis.go

@@ -11,6 +11,11 @@ import (
 // default logic provided by the sdk.
 type InflationCalculationFn func(ctx sdk.Context, minter Minter, params Params, bondedRatio sdk.Dec) sdk.Dec
 
+// DefaultInflationCalculationFn is the default function used to calculate inflation.
+func DefaultInflationCalculationFn(ctx sdk.Context, minter Minter, params Params, bondedRatio sdk.Dec) sdk.Dec {
+	return minter.NextInflationRate(params, bondedRatio)
+}
+
 // NewGenesisState creates a new GenesisState object
 func NewGenesisState(minter Minter, params Params) *GenesisState {
 	return &GenesisState{