Skip to content

Commit 27c238b

Browse files
RiceChuanmergify[bot]
authored andcommitted
docs: Quotation marks are used incorrectly. (#23071)
Signed-off-by: RiceChuan <[email protected]> (cherry picked from commit 45a41a5)
1 parent d254181 commit 27c238b

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

Diff for: docs/architecture/adr-031-msg-service.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ that `Msg` return types be captured using a protobuf extension field, ex:
2626
package cosmos.gov;
2727
2828
message MsgSubmitProposal
29-
option (cosmos_proto.msg_return) = uint64;
29+
option (cosmos_proto.msg_return) = "uint64";
3030
string delegator_address = 1;
3131
string validator_address = 2;
3232
repeated sdk.Coin amount = 3;

Diff for: docs/architecture/adr-033-protobuf-inter-module-comm.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ own account. These permissions are actually stored as a `[]string` array on the
4343
However, these permissions don’t really do much. They control what modules can be referenced in the `MintCoins`,
4444
`BurnCoins` and `DelegateCoins***` methods, but for one there is no unique object capability token that controls access —
4545
just a simple string. So the `x/upgrade` module could mint tokens for the `x/staking` module simple by calling
46-
`MintCoins(staking)`. Furthermore, all modules which have access to these keeper methods, also have access to
46+
`MintCoins("staking")`. Furthermore, all modules which have access to these keeper methods, also have access to
4747
`SetBalance` negating any other attempt at OCAPs and breaking even basic object-oriented encapsulation.
4848

4949
## Decision

Diff for: docs/architecture/adr-036-arbitrary-signature.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ The aim is being able to sign arbitrary messages, even using Ledger or similar H
3333

3434
As a result signed messages should look roughly like Cosmos SDK messages but **must not** be a valid on-chain transaction. `chain-id`, `account_number` and `sequence` can all be assigned invalid values.
3535

36-
Cosmos SDK 0.40 also introduces a concept of auth_info this can specify SIGN_MODES.
36+
Cosmos SDK 0.40 also introduces a concept of "auth_info" this can specify SIGN_MODES.
3737

3838
A spec should include an `auth_info` that supports SIGN_MODE_DIRECT and SIGN_MODE_LEGACY_AMINO.
3939

@@ -43,7 +43,7 @@ An offchain transaction follows these rules:
4343

4444
* the memo must be empty
4545
* nonce, sequence number must be equal to 0
46-
* chain-id must be equal to “”
46+
* chain-id must be equal to ""
4747
* fee gas must be equal to 0
4848
* fee amount must be an empty array
4949

0 commit comments

Comments
 (0)