Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rest server simulation query to estimate gas #56

Closed
ethanfrey opened this issue Feb 5, 2020 · 6 comments
Closed

Use rest server simulation query to estimate gas #56

ethanfrey opened this issue Feb 5, 2020 · 6 comments

Comments

@ethanfrey
Copy link
Contributor

There is some way for a query to do a dry run and return expected gas needed. This is used by the wasmdcli

Not high priority but it would be a nice feature

@faboweb
Copy link

faboweb commented Jul 2, 2020

From my experience, the gas simulation doesn't work and usually needs a high factor to not cause some txs to run out of gas.

@webmaster128
Copy link
Member

From my experience, the gas simulation doesn't work and usually needs a high factor to not cause some txs to run out of gas.

Thank you for sharing. What's Lunie's strategy to set gas values?

@faboweb
Copy link

faboweb commented Jul 2, 2020

We use high fixed values for the gas estimate and adjust the gas price to not cause mega high fees.

@ethanfrey
Copy link
Contributor Author

Thanks for chiming in @faboweb This is indeed the experience with many other apps. Simulate doesn't really simulate it all too well :(

I made this comment, hoping to improve the case for launchpad cosmos/cosmos-sdk#6522 (comment) but it looks like it was tentatively rejected cosmos/cosmos-sdk#6522 (comment)

That said, they did decide to make launchpad 0.39, so maybe there is the chance to get the improved simulation estimate inside the launchpad release so it makes sense

@ethanfrey
Copy link
Contributor Author

ethanfrey commented Jul 2, 2020

This seems a key issue that would lead to better estimates: cosmos/cosmos-sdk#4938

at the very least we should explore if this is actually a feasible approach for 0.38. Being that this is pretty trivial to implement and becoming more of a huge burden for clients, I think we should get this in for 0.38.
(cosmos/cosmos-sdk#4938 (comment))

🤞

Anyone else want to nudge on the issue?

@webmaster128
Copy link
Member

This is now tracked in #828

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants