Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix connection op for pods/log #255

Merged
merged 7 commits into from
May 14, 2023
Merged

Fix connection op for pods/log #255

merged 7 commits into from
May 14, 2023

Conversation

mruoss
Copy link
Collaborator

@mruoss mruoss commented May 14, 2023 •
edited
Loading

Fixes #254

API Docs

Requirements for all pull requests

  • Entry in CHANGELOG.md was created

Additional requirements for new features

  • New unit tests were created
  • New integration tests were created
  • PR description contains a link to the according kubernetes documentation

@mruoss mruoss force-pushed the fix-connection-op-for-logs branch from bf1f448 to 2959f1f Compare May 14, 2023 08:39
elliottneilclark
elliottneilclark approved these changes May 14, 2023
View reviewed changes
Copy link
Contributor

@elliottneilclark elliottneilclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mruoss mruoss merged commit f4a0e72 into develop May 14, 2023
9 checks passed
@mruoss mruoss deleted the fix-connection-op-for-logs branch May 14, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elliottneilclark elliottneilclark elliottneilclark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support pods/logs subresource streaming
2 participants
@mruoss @elliottneilclark