Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Controller.apply_dependents/1 #89

Closed
coryodaniel opened this issue Feb 17, 2020 · 0 comments · Fixed by #166
Closed

Add Controller.apply_dependents/1 #89

coryodaniel opened this issue Feb 17, 2020 · 0 comments · Fixed by #166
Labels
good first issue Good for newcomers
Milestone

Comments

@coryodaniel
Copy link
Owner

This would be an abstraction over K8s.Client.run/N or K8s.Client.async/N.

This could be helpful with #49 #88

A function that will take a list of k8s resource definitions and creates them all.

The term here apply being borrowed from kubectl. It would add or modify resources.

def added(my_crd_added_event = %{}) do
  deployment = ...
  service = ...
  config_map = ...
  dependents = [deployment, service, config_map]

  case apply_dependents(my_crd_added_event, dependents) do
    {:ok, resources} -> IO.puts "Yay"
    {:error, resources_and_errors} -> IO.puts "boo"
  end
end

TBD: Should this operate on HTTP response or poll for k8s resource status.

@coryodaniel coryodaniel added this to the 0.5 release milestone Feb 17, 2020
@coryodaniel coryodaniel modified the milestones: 0.5 release, 1.0 release Jun 2, 2020
@mruoss mruoss added the good first issue Good for newcomers label Oct 2, 2022
@mruoss mruoss removed this from the 1.0 release milestone Oct 2, 2022
@mruoss mruoss linked a pull request Oct 26, 2022 that will close this issue
@mruoss mruoss added this to the 1.0 release milestone Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants