Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle missed deletion of non-k8s resources #72

Closed
coryodaniel opened this issue Oct 14, 2019 · 2 comments
Closed

Handle missed deletion of non-k8s resources #72

coryodaniel opened this issue Oct 14, 2019 · 2 comments

Comments

@coryodaniel
Copy link
Owner

coryodaniel commented Oct 14, 2019 •
edited
Loading

This is definitely an edge case.

  • a controller uses an non-k8s API to create an artifact (e.g.: s3 bucket/object)
  • the operator goes offline for some reason
  • a human operator deletes the CRD resource
  • Kubernetes garbage collection deletes the CRD resources dependents Automatically inject ownerReferences #49

In this case deleted/1 would not have been called and the external artifact would still exist.
@coryodaniel coryodaniel changed the title Resource History Handle missed deletion of non-k8s resources Feb 17, 2020
@pedep
Copy link
Contributor

pedep commented Jun 3, 2020

I think this is a pretty common scenario
Kubernetes already has a concept for handling this type of synchronization
https://kubernetes.io/docs/tasks/access-kubernetes-api/custom-resources/custom-resource-definitions/#finalizers

@coryodaniel
Copy link
Owner Author

I need to add finalized support #6, but waiting until after 1.0.

I don’t know why I added this twice :)

@mruoss mruoss mentioned this issue Feb 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@coryodaniel @pedep