From 65b8def8febc2b919d0cfaac1bc0845fa6530e4f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jo=C5=BEe=20Fortun?= <joze.fortun@gmail.com>
Date: Mon, 19 Aug 2024 15:39:37 +0200
Subject: [PATCH 1/2] Fix import recordID mapping on UI

---
 .../Public/Record/Importer/ErrorReport.vue    |   8 +-
 .../Public/Record/Importer/FieldMatch.vue     | 100 +++++++++++-------
 .../Public/Record/Importer/FileUpload.vue     |   1 +
 .../Public/Record/Importer/Progress.vue       |  77 +++++++++-----
 lib/vue/src/components/progress/CProgress.vue |   6 ++
 locale/en/corteza-webapp-compose/block.yaml   |  11 +-
 6 files changed, 131 insertions(+), 72 deletions(-)

diff --git a/client/web/compose/src/components/Public/Record/Importer/ErrorReport.vue b/client/web/compose/src/components/Public/Record/Importer/ErrorReport.vue
index 695b4eb50a..be8c2f71d7 100644
--- a/client/web/compose/src/components/Public/Record/Importer/ErrorReport.vue
+++ b/client/web/compose/src/components/Public/Record/Importer/ErrorReport.vue
@@ -80,11 +80,11 @@
 
     <div slot="footer">
       <b-button
-        variant="dark"
+        variant="light"
         class="float-right"
         @click="$emit('close')"
       >
-        {{ $t('general.label.ok') }}
+        {{ $t('general:label.close') }}
       </b-button>
     </div>
   </b-card>
@@ -133,12 +133,12 @@ export default {
         {
           key: 'k',
           label: this.$t('recordList.import.report.error'),
-          tdClass: 'border-top text-truncate pointer',
+          tdClass: 'border-top',
         },
         {
           key: 'v',
           label: this.$t('recordList.import.report.count'),
-          tdClass: 'border-top text-truncate pointer',
+          tdClass: 'border-top',
         },
       ]
     },
diff --git a/client/web/compose/src/components/Public/Record/Importer/FieldMatch.vue b/client/web/compose/src/components/Public/Record/Importer/FieldMatch.vue
index 3a1fdd38de..0a8ee8822c 100644
--- a/client/web/compose/src/components/Public/Record/Importer/FieldMatch.vue
+++ b/client/web/compose/src/components/Public/Record/Importer/FieldMatch.vue
@@ -1,23 +1,24 @@
 <template>
-  <b-card>
-    <b-form-group>
-      <div class="mb-4">
-        <label>
-          {{ $t('recordList.import.matchFields') }}
-        </label>
-        <br>
-        <small
-          v-if="hasRequiredFileFields"
-        >
-          {{ $t('recordList.import.hasRequiredFileFields') }}: {{ showRequiredFields }}
-        </small>
+  <div class="d-flex flex-column h-100 overflow-hidden">
+    <b-form-group
+      :label="$t('recordList.import.matchFields')"
+      label-class="text-primary p-3"
+      class="flex-fill overflow-auto mb-0"
+    >
+      <div
+        v-if="hasRequiredFileFields"
+        class="small px-3 mb-3"
+      >
+        {{ $t('recordList.import.hasRequiredFileFields') }}: {{ showRequiredFields }}
       </div>
 
       <b-table
         :fields="tableFields"
         :items="rows"
         head-variant="light"
-        class="field-table"
+        sticky-header
+        style="max-height: 70vh;"
+        class="field-table mb-0"
       >
         <template #head(selected)>
           <b-form-checkbox
@@ -34,27 +35,27 @@
           />
         </template>
         <template #cell(moduleField)="data">
-          <b-form-select
+          <c-input-select
             v-model="data.item.moduleField"
             :options="moduleFields"
-            @change="moduleChanged(data)"
+            :reduce="o => o.name"
+            :placeholder="$t('recordList.import.pickModuleField')"
+            :class="{ 'border border-danger': data.item.selected && !data.item.moduleField }"
+            @input="moduleChanged(data)"
+          />
+          <span
+            v-if="data.item.fileColumn === 'id'"
+            class="small text-muted"
           >
-            <template slot="first">
-              <option
-                :value="undefined"
-                disabled
-              >
-                {{ $t('recordList.import.pickModuleField') }}
-              </option>
-            </template>
-          </b-form-select>
+            {{ $t('recordList.import.idFieldDescription') }}
+          </span>
         </template>
       </b-table>
     </b-form-group>
 
-    <div slot="footer">
+    <div class="mt-auto p-3">
       <b-button
-        variant="outline-dark"
+        variant="light"
         class="float-left"
         @click="$emit('back')"
       >
@@ -70,7 +71,7 @@
         {{ $t('general.label.import') }}
       </b-button>
     </div>
-  </b-card>
+  </div>
 </template>
 
 <script>
@@ -139,16 +140,22 @@ export default {
         {
           key: 'moduleField',
           label: this.$t('recordList.import.moduleFields'),
+          thStyle: 'width: 25rem',
         },
       ]
     },
 
     moduleFields () {
-      return this.module.fields
-        .filter(({ kind }) => !['File'].includes(kind))
+      return [
+        ...this.module.fields,
+        ...this.module.systemFields().map(({ name }) => {
+          return {
+            label: this.$t(`field:system.${name}`),
+            name,
+          }
+        }),
+      ].filter(({ kind }) => !['File'].includes(kind))
         .map(field => field.isRequired === true ? { ...field, label: field.label + '*' } : field)
-        .map(({ name: value, label }) => ({ value, text: label || value }))
-        .sort((a, b) => a.text.localeCompare(b.text))
     },
 
     requiredFields () {
@@ -187,24 +194,39 @@ export default {
   created () {
     // Prep row object for us to alter
     const { fields = {} } = this.session
-    const moduleFields = {}
+
+    const moduleFields = {
+      'id': 'recordID',
+    }
+
     this.module.fields.forEach(({ name }) => {
       moduleFields[name] = name
     })
 
+    this.module.systemFields().forEach(({ name }) => {
+      moduleFields[name] = name
+    })
+
     this.rows = Object.entries(fields)
-      .map(([fileColumn, moduleField]) => ({
-        selected: false,
-        fileColumn,
-        moduleField: moduleField || moduleFields[fileColumn],
-      }))
+      .map(([fileColumn, moduleField]) => {
+        moduleField = moduleField || moduleFields[fileColumn]
+
+        return {
+          selected: false,
+          fileColumn,
+          moduleField,
+        }
+      })
   },
 
   methods: {
     moduleChanged (data) {
-      const result = this.rows.find(row => row.fileColumn === data.item.fileColumn)
-      result.selected = true
+      if (data.item.moduleField) {
+        const result = this.rows.find(row => row.moduleField === data.item.moduleField)
+        result.selected = true
+      }
     },
+
     nextStep () {
       if (!this.canContinue) {
         return
diff --git a/client/web/compose/src/components/Public/Record/Importer/FileUpload.vue b/client/web/compose/src/components/Public/Record/Importer/FileUpload.vue
index c0a9e7c8a1..05ead6ae74 100644
--- a/client/web/compose/src/components/Public/Record/Importer/FileUpload.vue
+++ b/client/web/compose/src/components/Public/Record/Importer/FileUpload.vue
@@ -37,6 +37,7 @@
       class="text-right"
     >
       <b-button
+        variant="primary"
         :disabled="!canContinue"
         @click="fileUploaded"
       >
diff --git a/client/web/compose/src/components/Public/Record/Importer/Progress.vue b/client/web/compose/src/components/Public/Record/Importer/Progress.vue
index 5d4dee90ed..6818678403 100644
--- a/client/web/compose/src/components/Public/Record/Importer/Progress.vue
+++ b/client/web/compose/src/components/Public/Record/Importer/Progress.vue
@@ -1,37 +1,62 @@
 <template>
   <b-card>
-    <b-form-group class="my-4 mx-4">
-      <b-progress
-        :max="progress.entryCount"
-        show-value
-        show-progress
-        variant="primary"
-        height="80px"
-        class="bg-light"
-      >
-        <b-progress-bar
-          :value="progress.completed"
-          class="progress-label"
-          variant="primary"
-        >
-          <span class="font-weight-bold">{{ $t('recordList.import.progressRatio', progress) }}</span>
-        </b-progress-bar>
-      </b-progress>
-    </b-form-group>
-
-    <b-form-group class="mx-4 mb-0">
-      <span
-        v-if="progress.finishedAt && !progress.failed"
-        class="text-success"
+    <c-progress
+      :value="progress.completed"
+      :max="progress.entryCount"
+      labeled
+      progress
+      :animated="!progress.finishedAt"
+      :relative="false"
+      variant="success"
+      text-style="font-size: 1.5rem;"
+      style="height: 4rem;"
+      class="mb-4"
+    />
+
+    <div
+      v-if="!progress.finishedAt"
+      class="d-flex"
+    >
+      <span class="text-secondary">
+        <b-spinner
+          variant="secondary"
+          small
+        />
+        {{ $t('recordList.import.importing') }}
+      </span>
+
+      <b-button
+        variant="light"
+        class="ml-auto"
+        @click="$emit('close')"
       >
+        {{ $t('general:label.cancel') }}
+      </b-button>
+    </div>
 
+    <div
+      v-if="progress.finishedAt && !progress.failed"
+      class="d-flex"
+    >
+      <span class="text-success">
         {{ $t('recordList.import.success') }}
       </span>
-    </b-form-group>
+
+      <b-button
+        variant="light"
+        class="ml-auto"
+        @click="$emit('close')"
+      >
+        {{ $t('general:label.close') }}
+      </b-button>
+    </div>
   </b-card>
 </template>
 
 <script>
+import { components } from '@cortezaproject/corteza-vue'
+const { CProgress } = components
+
 let toHandle = null
 
 export default {
@@ -39,6 +64,10 @@ export default {
     namespaces: 'block',
   },
 
+  components: {
+    CProgress,
+  },
+
   props: {
     session: {
       type: Object,
diff --git a/lib/vue/src/components/progress/CProgress.vue b/lib/vue/src/components/progress/CProgress.vue
index 3603134fac..d1ef66222d 100644
--- a/lib/vue/src/components/progress/CProgress.vue
+++ b/lib/vue/src/components/progress/CProgress.vue
@@ -12,6 +12,7 @@
       <strong
         :class="textVariant"
         class="d-flex align-items-center justify-content-center position-absolute mb-0 w-100"
+        :style="textStyle"
       >
         {{ progressLabel }}
       </strong>
@@ -67,6 +68,11 @@ export default {
       type: Array,
       default: () => [],
     },
+
+    textStyle: {
+      type: String,
+      default: '',
+    },
   },
 
   computed: {
diff --git a/locale/en/corteza-webapp-compose/block.yaml b/locale/en/corteza-webapp-compose/block.yaml
index 527d116afc..a15f18266f 100644
--- a/locale/en/corteza-webapp-compose/block.yaml
+++ b/locale/en/corteza-webapp-compose/block.yaml
@@ -401,13 +401,17 @@ recordList:
     failed: 'Something went wrong during the import. Please try again: {{failReason}}'
     fileColumns: File columns
     hasRequiredFileFields: 'This module has required file upload fields'
-    matchFields: 'Match imported columns with existing ones:'
+    matchFields: 'Match imported columns with existing ones'
     moduleFields: Module fields
     onError: If any record fails to import
     onErrorFail: Cancel import
     onErrorSkip: Skip record
     pickModuleField: Pick a module field
-    progressRatio: '{{completed}} / {{entryCount}} rows'
+    importing: Importing records
+    success: Import successful
+    to: Import to {{modulename}}
+    uploadFile: Upload the file you want to import (.csv or JSON format)
+    idFieldDescription: Records with matching ID's will be updated.
     report:
       count: Number of records
       detectedErrors: Detected errors
@@ -421,9 +425,6 @@ recordList:
       startedAt: Started At
       title: Record import error report
       totalRecords: Total records
-    success: Import successful
-    to: Import to {{modulename}}
-    uploadFile: Upload the file you want to import (.csv or JSON format)
   label: Record list
   moduleFootnote: Modules without a {{0}} can only be used in a record list as an inline editor
   moduleFieldsFootnote : If no fields are selected, the default fields will be shown

From f17a9da29c861ad5b249cf137835949410e3335d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Toma=C5=BE=20Jerman?= <tomaz.jerman121@gmail.com>
Date: Wed, 21 Aug 2024 15:58:55 +0200
Subject: [PATCH 2/2] Allow record updates via envoy on matching IDs

---
 server/compose/envoy/record_datasource.go     |  4 ++
 server/compose/envoy/store_decode.go          |  5 +-
 server/compose/envoy/store_encode.go          |  7 +-
 .../compose/envoy/store_encode_datasource.go  | 64 +++++++++++++++---
 server/compose/rest/record.go                 | 67 +++++++++++++++++++
 server/compose/service/import_session.go      |  2 +-
 6 files changed, 134 insertions(+), 15 deletions(-)

diff --git a/server/compose/envoy/record_datasource.go b/server/compose/envoy/record_datasource.go
index 9193cc7f14..db555fc648 100644
--- a/server/compose/envoy/record_datasource.go
+++ b/server/compose/envoy/record_datasource.go
@@ -17,6 +17,8 @@ type (
 		Mapping  envoyx.DatasourceMapping
 		Provider envoyx.Provider
 
+		CheckExisting func(ctx context.Context, ref ...[]string) ([]uint64, error)
+
 		currentIndex int
 
 		// Reusable buffer for reading records
@@ -25,6 +27,8 @@ type (
 		// Index to map from ref to ID
 		// @todo we might need to flush these to the disc in case a huge dataset is passed in
 		refToID map[string]uint64
+		// @todo might be worth putting both into one map; not sure how much space we'd save up
+		existingIDs map[uint64]bool
 	}
 
 	// iteratorProvider is a wrapper around the dal.Iterator to conform to the
diff --git a/server/compose/envoy/store_decode.go b/server/compose/envoy/store_decode.go
index 7251ab2e2f..38ee7ee370 100644
--- a/server/compose/envoy/store_decode.go
+++ b/server/compose/envoy/store_decode.go
@@ -240,8 +240,9 @@ func (d StoreDecoder) decodeRecordDatasource(ctx context.Context, s store.Storer
 	}
 
 	ou := &RecordDatasource{
-		Provider: &iteratorProvider{iter: iter},
-		refToID:  make(map[string]uint64),
+		Provider:    &iteratorProvider{iter: iter},
+		refToID:     make(map[string]uint64),
+		existingIDs: make(map[uint64]bool),
 		// @todo consider providing defaults from the outside
 		Mapping: envoyx.DatasourceMapping{
 			KeyField:    []string{"id"},
diff --git a/server/compose/envoy/store_encode.go b/server/compose/envoy/store_encode.go
index 7f0b14f761..3e9fddba83 100644
--- a/server/compose/envoy/store_encode.go
+++ b/server/compose/envoy/store_encode.go
@@ -153,9 +153,14 @@ func (e StoreEncoder) validateRecord(*types.Record) (err error) {
 }
 
 func (e StoreEncoder) prepare(ctx context.Context, p envoyx.EncodeParams, s store.Storer, rt string, nn envoyx.NodeSet) (err error) {
+	dl, err := e.grabDal(p)
+	if err != nil {
+		return
+	}
+
 	switch rt {
 	case ComposeRecordDatasourceAuxType:
-		return e.prepareRecordDatasource(ctx, p, s, nn)
+		return e.prepareRecordDatasource(ctx, p, s, dl, nn)
 	}
 
 	return
diff --git a/server/compose/envoy/store_encode_datasource.go b/server/compose/envoy/store_encode_datasource.go
index 89203c7761..7146ac7d75 100644
--- a/server/compose/envoy/store_encode_datasource.go
+++ b/server/compose/envoy/store_encode_datasource.go
@@ -28,7 +28,7 @@ var (
 	rvFormatter = values.Formatter()
 )
 
-func (e StoreEncoder) prepareRecordDatasource(ctx context.Context, p envoyx.EncodeParams, s store.Storer, nn envoyx.NodeSet) (err error) {
+func (e StoreEncoder) prepareRecordDatasource(ctx context.Context, p envoyx.EncodeParams, s store.Storer, dl dal.FullService, nn envoyx.NodeSet) (err error) {
 	// @todo match existing records; for now use just the ID like V1
 
 	for _, n := range nn {
@@ -41,7 +41,7 @@ func (e StoreEncoder) prepareRecordDatasource(ctx context.Context, p envoyx.Enco
 			panic("unexpected datasource type: node expecting type of RecordDatasource")
 		}
 
-		err = e.prepareRecords(ctx, p, s, ds)
+		err = e.prepareRecords(ctx, p, s, dl, ds, nn)
 		if err != nil {
 			return
 		}
@@ -54,7 +54,7 @@ func (e StoreEncoder) prepareRecordDatasource(ctx context.Context, p envoyx.Enco
 	return
 }
 
-func (e StoreEncoder) prepareRecords(ctx context.Context, p envoyx.EncodeParams, s store.Storer, ds *RecordDatasource) (err error) {
+func (e StoreEncoder) prepareRecords(ctx context.Context, p envoyx.EncodeParams, s store.Storer, dl dal.FullService, ds *RecordDatasource, nn envoyx.NodeSet) (err error) {
 	var (
 		aux   = make(map[string]string)
 		more  bool
@@ -62,6 +62,15 @@ func (e StoreEncoder) prepareRecords(ctx context.Context, p envoyx.EncodeParams,
 	)
 
 	ds.refToID = make(map[string]uint64)
+	ds.existingIDs = make(map[uint64]bool)
+
+	// Just so we don't need to do a branch later down the line
+	cex := ds.CheckExisting
+	if cex == nil || len(ds.Mapping.KeyField) == 0 {
+		cex = func(ctx context.Context, ref ...[]string) ([]uint64, error) {
+			return make([]uint64, len(ref)), nil
+		}
+	}
 
 	for {
 		ident, more, err = ds.Next(ctx, aux)
@@ -69,7 +78,21 @@ func (e StoreEncoder) prepareRecords(ctx context.Context, p envoyx.EncodeParams,
 			return
 		}
 
-		ds.AddRef(id.Next(), ident...)
+		// @todo we'll need to batch these up
+		existing, err := cex(ctx, ident)
+		if err != nil {
+			return err
+		}
+
+		if existing[0] != 0 {
+			ds.existingIDs[existing[0]] = true
+		}
+
+		if existing[0] == 0 {
+			existing[0] = id.Next()
+		}
+
+		ds.AddRef(existing[0], ident...)
 
 		// Construct a simple record for basic validation/preprocessing
 		rec := types.Record{}
@@ -143,7 +166,8 @@ func (e StoreEncoder) encodeRecordDatasource(ctx context.Context, p envoyx.Encod
 
 	var (
 		rec     types.Record
-		records types.RecordSet
+		creates types.RecordSet
+		updates types.RecordSet
 		rve     *types.RecordValueErrorSet
 	)
 	for {
@@ -185,15 +209,29 @@ func (e StoreEncoder) encodeRecordDatasource(ctx context.Context, p envoyx.Encod
 			}
 
 			ax := rec
-			records = append(records, &ax)
 
-			if len(records) > recordBatchMaxChunk {
-				err = dalutils.ComposeRecordCreate(ctx, dl, mod, records...)
+			if ds.existingIDs[rec.ID] {
+				updates = append(updates, &ax)
+			} else {
+				creates = append(creates, &ax)
+			}
+
+			if len(creates) > recordBatchMaxChunk {
+				err = dalutils.ComposeRecordCreate(ctx, dl, mod, creates...)
+				if err != nil {
+					return
+				}
+
+				creates = make(types.RecordSet, 0, recordBatchMaxChunk/2)
+			}
+
+			if len(updates) > recordBatchMaxChunk {
+				err = dalutils.ComposeRecordUpdate(ctx, dl, mod, updates...)
 				if err != nil {
 					return
 				}
 
-				records = make(types.RecordSet, 0, recordBatchMaxChunk/2)
+				updates = make(types.RecordSet, 0, recordBatchMaxChunk/2)
 			}
 			return
 		}()
@@ -213,8 +251,12 @@ func (e StoreEncoder) encodeRecordDatasource(ctx context.Context, p envoyx.Encod
 		}
 	}
 
-	if len(records) > 0 {
-		err = dalutils.ComposeRecordCreate(ctx, dl, mod, records...)
+	if len(creates) > 0 {
+		err = dalutils.ComposeRecordCreate(ctx, dl, mod, creates...)
+	}
+
+	if len(updates) > 0 {
+		err = dalutils.ComposeRecordUpdate(ctx, dl, mod, updates...)
 	}
 	return
 }
diff --git a/server/compose/rest/record.go b/server/compose/rest/record.go
index 786b114674..52e84b435f 100644
--- a/server/compose/rest/record.go
+++ b/server/compose/rest/record.go
@@ -11,6 +11,7 @@ import (
 	"strings"
 	"time"
 
+	"github.com/cortezaproject/corteza/server/compose/dalutils"
 	composeEnvoy "github.com/cortezaproject/corteza/server/compose/envoy"
 	"github.com/cortezaproject/corteza/server/compose/rest/request"
 	"github.com/cortezaproject/corteza/server/compose/service"
@@ -26,6 +27,7 @@ import (
 	"github.com/cortezaproject/corteza/server/pkg/filter"
 	"github.com/cortezaproject/corteza/server/pkg/revisions"
 	"github.com/cortezaproject/corteza/server/store"
+	"github.com/spf13/cast"
 )
 
 type (
@@ -530,6 +532,17 @@ func (ctrl *Record) ImportRun(ctx context.Context, r *request.RecordImportRun) (
 				Placeholder: true,
 			}
 
+			keyField := []string{}
+
+			// Check if we're mapping the ID field even
+			for _, v := range importSession.Fields {
+				auxf := strings.ToLower(v)
+
+				if auxf == "id" || auxf == "recordid" || auxf == "record_id" {
+					keyField = []string{importSession.Key}
+				}
+			}
+
 			node = &envoyx.Node{
 				Datasource: &composeEnvoy.RecordDatasource{
 					Mapping: envoyx.DatasourceMapping{
@@ -537,10 +550,62 @@ func (ctrl *Record) ImportRun(ctx context.Context, r *request.RecordImportRun) (
 						References:  map[string]string{},
 						Scope:       map[string]string{},
 						Defaultable: false,
+						KeyField:    keyField,
 						Mapping: envoyx.FieldMapping{
 							Map: fieldMapping,
 						},
 					},
+
+					CheckExisting: func(ctx context.Context, idents ...[]string) (out []uint64, err error) {
+						qp := make([]string, 0, len(idents))
+						for _, ident := range idents {
+							if len(ident) != 1 {
+								continue
+							}
+
+							rid := cast.ToUint64(ident[0])
+							if rid == 0 {
+								continue
+							}
+
+							qp = append(qp, fmt.Sprintf("recordID='%d'", rid))
+						}
+
+						bong, _, err := dalutils.ComposeRecordsList(ctx, dal.Service(), mod, types.RecordFilter{
+							ModuleID:    mod.ID,
+							NamespaceID: mod.NamespaceID,
+							Query:       strings.Join(qp, " OR "),
+						})
+						if err != nil {
+							return
+						}
+
+						for _, ident := range idents {
+							if len(ident) != 1 {
+								out = append(out, 0)
+								continue
+							}
+
+							rid := cast.ToUint64(ident[0])
+							if rid == 0 {
+								out = append(out, 0)
+								continue
+							}
+
+							// Find the correct one in the fetched slice
+							got := uint64(0)
+							for _, r := range bong {
+								if r.ID == rid {
+									got = r.ID
+									break
+								}
+							}
+
+							out = append(out, got)
+						}
+
+						return
+					},
 				},
 				ResourceType: composeEnvoy.ComposeRecordDatasourceAuxType,
 				Identifiers:  envoyx.MakeIdentifiers(importSession.Name),
@@ -573,6 +638,8 @@ func (ctrl *Record) ImportRun(ctx context.Context, r *request.RecordImportRun) (
 				return
 			}
 
+			// panic("AAAAAA")
+
 			{
 				// @todo this is temporary because the service's logic is a bit flawed for this case
 				err = storeEncoder.Prepare(ctx, encodeParams, composeEnvoy.ComposeRecordDatasourceAuxType, envoyx.NodeSet{node})
diff --git a/server/compose/service/import_session.go b/server/compose/service/import_session.go
index ac2a6e3bbd..a824a4a637 100644
--- a/server/compose/service/import_session.go
+++ b/server/compose/service/import_session.go
@@ -101,7 +101,7 @@ func (svc *importSession) Create(ctx context.Context, f io.ReadSeeker, name, con
 
 		// @todo improve this bit
 		k := prepKey(f)
-		if k == "id" || k == "recordid" {
+		if k == "id" || k == "recordid" || k == "record_id" {
 			sh.Key = f
 		}
 	}