From 43f8ddb86623e3147b6fd029530a0491f4759152 Mon Sep 17 00:00:00 2001 From: Marco Pracucci Date: Fri, 15 Jan 2021 18:04:00 +0100 Subject: [PATCH] Enforce seconds unit in the querier wall time log Signed-off-by: Marco Pracucci --- CHANGELOG.md | 2 +- pkg/frontend/transport/handler.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e4de9d12d1b..5e731d47f83 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,7 +10,7 @@ * `-bigtable.grpc-use-gzip-compression`: use `-bigtable.grpc-compression` instead * `-ingester.client.grpc-use-gzip-compression`: use `-ingester.client.grpc-compression` instead * `-querier.frontend-client.grpc-use-gzip-compression`: use `-querier.frontend-client.grpc-compression` instead -* [CHANGE] Querier: it's not required to set `-frontend.query-stats-enabled=true` in the querier anymore to enable query statistics logging in the query-frontend. The flag is now required to be configured only in the query-frontend and it will be propagated to the queriers. #3595 +* [CHANGE] Querier: it's not required to set `-frontend.query-stats-enabled=true` in the querier anymore to enable query statistics logging in the query-frontend. The flag is now required to be configured only in the query-frontend and it will be propagated to the queriers. #3595 #3693 * [CHANGE] Blocks storage: compactor is now required when running a Cortex cluster with the blocks storage, because it also keeps the bucket index updated. #3583 * [CHANGE] Blocks storage: block deletion marks are now stored in a per-tenant global markers/ location too, other than within the block location. The compactor, at startup, will copy deletion marks from the block location to the global location. This migration is required only once, so you can safely disable it via `-compactor.block-deletion-marks-migration-enabled=false` once new compactor has successfully started once in your cluster. #3583 * [CHANGE] OpenStack Swift: the default value for the `-ruler.storage.swift.container-name` and `-swift.container-name` config options has changed from `cortex` to empty string. If you were relying on the default value, you should set it back to `cortex`. #3660 diff --git a/pkg/frontend/transport/handler.go b/pkg/frontend/transport/handler.go index ac350aa0989..d0cdbf871d3 100644 --- a/pkg/frontend/transport/handler.go +++ b/pkg/frontend/transport/handler.go @@ -161,7 +161,7 @@ func (f *Handler) reportQueryStats(r *http.Request, queryString url.Values, quer "method", r.Method, "path", r.URL.Path, "response_time", queryResponseTime, - "query_wall_time", stats.LoadWallTime(), + "query_wall_time_seconds", stats.LoadWallTime().Seconds(), }, formatQueryString(queryString)...) level.Info(util.WithContext(r.Context(), f.log)).Log(logMessage...)