From d50a6a168dbb0bb34667b5de1cfacc2346411c0d Mon Sep 17 00:00:00 2001 From: Ganesh Vernekar Date: Tue, 5 May 2020 19:48:07 +0530 Subject: [PATCH 1/2] Remove experimental tag on WAL Signed-off-by: Ganesh Vernekar --- CHANGELOG.md | 1 + docs/production/ingesters-with-wal.md | 2 -- pkg/ingester/wal.go | 2 -- 3 files changed, 1 insertion(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 908b544b78b..07a84706cb7 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -48,6 +48,7 @@ * [ENHANCEMENT] query-frontend now also logs the POST data of long queries. #2481 * [ENHANCEMENT] Experimental WAL: Ingester WAL records now have type header and the custom WAL records have been replaced by Prometheus TSDB's WAL records. Old records will not be supported from 1.3 onwards. Note: once this is deployed, you cannot downgrade without data loss. #2436 * [ENHANCEMENT] Redis Cache: Added `idle_timeout`, `wait_on_pool_exhaustion` and `max_conn_lifetime` options to redis cache configuration. #2550 +* [ENHANCEMENT] WAL: the experimental tag has been removed on the WAL in ingesters. * [BUGFIX] Ruler: Ensure temporary rule files with special characters are properly mapped and cleaned up. #2506 * [BUGFIX] Fixes #2411, Ensure requests are properly routed to the prometheus api embedded in the query if `-server.path-prefix` is set. #2372 * [BUGFIX] Experimental TSDB: fixed chunk data corruption when querying back series using the experimental blocks storage. #2400 diff --git a/docs/production/ingesters-with-wal.md b/docs/production/ingesters-with-wal.md index b71f0da3d32..40442959dca 100644 --- a/docs/production/ingesters-with-wal.md +++ b/docs/production/ingesters-with-wal.md @@ -9,8 +9,6 @@ Currently the ingesters running in the chunks storage mode, store all their data To use WAL, there are some changes that needs to be made in the deployment. -_The WAL is currently considered experimental._ - ## Changes to deployment 1. Since ingesters need to have the same persistent volume across restarts/rollout, all the ingesters should be run on [statefulset](https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/) with fixed volumes. diff --git a/pkg/ingester/wal.go b/pkg/ingester/wal.go index 9a2ac0b7c54..80d7ce6c5e3 100644 --- a/pkg/ingester/wal.go +++ b/pkg/ingester/wal.go @@ -110,8 +110,6 @@ func newWAL(cfg WALConfig, userStatesFunc func() map[string]*userState, register return &noopWAL{}, nil } - util.WarnExperimentalUse("Chunks WAL") - var walRegistry prometheus.Registerer if registerer != nil { walRegistry = prometheus.WrapRegistererWith(prometheus.Labels{"kind": "wal"}, registerer) From 7d148b9176960d45a9e8b34ce4d34063bc8bed68 Mon Sep 17 00:00:00 2001 From: Ganesh Vernekar Date: Mon, 11 May 2020 14:27:39 +0530 Subject: [PATCH 2/2] Fix other places Signed-off-by: Ganesh Vernekar --- docs/architecture.md | 2 +- docs/configuration/v1-guarantees.md | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/docs/architecture.md b/docs/architecture.md index 02c206ff4d0..26b70fe61bc 100644 --- a/docs/architecture.md +++ b/docs/architecture.md @@ -180,7 +180,7 @@ The **write-ahead log** (WAL) is used to write to a persistent local disk all in Contrary to the sole replication and given the persistent local disk data is not lost, in the event of multiple ingesters failure each ingester will recover the in-memory series samples from WAL upon subsequent restart. The replication is still recommended in order to ensure no temporary failures on the read path in the event of a single ingester failure. -The WAL for the chunks storage is an experimental feature (disabled by default), while it's always enabled for the blocks storage. +The WAL for the chunks storage is disabled by default, while it's always enabled for the blocks storage. #### Ingesters write de-amplification diff --git a/docs/configuration/v1-guarantees.md b/docs/configuration/v1-guarantees.md index 90f3caff360..cedf5f4503a 100644 --- a/docs/configuration/v1-guarantees.md +++ b/docs/configuration/v1-guarantees.md @@ -35,7 +35,6 @@ Cortex is an actively developed project and we want to encourage the introductio Currently experimental features are: - TSDB block storage. -- Ingester chunk WAL. - Cassandra storage engine. - Azure blob storage. - Zone awareness based replication.