Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Crab Bombs into a Global Script #118

Open
Causeless opened this issue Mar 5, 2024 · 0 comments
Open

Convert Crab Bombs into a Global Script #118

Causeless opened this issue Mar 5, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Causeless
Copy link
Contributor

Causeless commented Mar 5, 2024

Describe the Problem and Suggested Improvement
Crab bombing was an effect caused by old technical limitations to the game that were removed a long, long time ago. Effectively, the combination of crabs being free with very restrictive MOID limit meant that spamming crabs would quickly blow this limit, causing all non-brain actors to gib.

In CCCP build, this was readded to the code as an explicit 'feature' for nostalgia purposes, but it's such a specific detail that it ought to be removed from the C++ entirely and done via script.

Describe Additional Work Required Before Improvement Can be Made
The old crab bomb settings will need to be removed from SettingsMan, and have the vestigial crab bomb C++ hacks removed. Afterwards, a global script can be created that, when enabled, will re-introduce the crab bomb behaviour.

Note that global scripts, as of yet, lack the ability to have user-variable settings, e.g the crab bomb threshold. I suggest that the theshold is just set to its default value of 42 in the script.

Additional context
The commit that added the crab bombs was ce87d40.

@Causeless Causeless added enhancement New feature or request good first issue Good for newcomers labels Mar 5, 2024
@WilczyBober3 WilczyBober3 self-assigned this Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants