Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should We Use Sass Modules? #544

Open
MKwenhua opened this issue Nov 29, 2017 · 2 comments
Open

Should We Use Sass Modules? #544

MKwenhua opened this issue Nov 29, 2017 · 2 comments

Comments

@MKwenhua
Copy link
Contributor

MKwenhua commented Nov 29, 2017

@mrfantasticwonders @toastercup
After encountering an issue with css class definition precedence, which resulted in the inability to modify the background gradient on an element by applying additional classes I thought that maybe being able to specify the order of classes in module imports could alleviate that.

Anyways, I am fine either way but would just like to hear your input.

About Sass Modules:
https://medium.com/@marcmintel/how-to-use-the-module-pattern-in-your-scss-sass-stylesheets-89fe38a6e1f3

Anyways Below I have included some articles one Pro CSS Modules, and the other Anti CSS Modules.

Pro:
https://m.alphasights.com/css-evolution-from-css-sass-bem-css-modules-to-styled-components-d4c1da3a659b

Con:
https://medium.com/@gajus/stop-using-css-in-javascript-for-web-development-fa32fb873dcc

@toastercup toastercup changed the title Discussion: Should We Use SASS Modules For Cortex? Discussion: Should We Use Sass Modules For Cortex? Nov 29, 2017
@MKwenhua
Copy link
Contributor Author

MKwenhua commented Nov 30, 2017

One thing I thought of this morning is about a potential benefit of CSS Modules is it would make finding relevant styles much faster and easier. Additionally it could make removing unused dead styles safer since the modules would be name spaced.

@toastercup toastercup changed the title Discussion: Should We Use Sass Modules For Cortex? Should We Use Sass Modules For Cortex? Jan 13, 2018
@toastercup toastercup changed the title Should We Use Sass Modules For Cortex? Should we use Sass Modules? Jan 13, 2018
@toastercup toastercup changed the title Should we use Sass Modules? Should We Use Sass Modules? Jan 13, 2018
@MKwenhua
Copy link
Contributor Author

Just an update:
Since I created this issue I have had hands on experience with CSS/SASS modules and have concluded they present more complications than any solutions they offer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant