Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MakeInstall.bat doesn't show ANY devices #236

Open
Otus9051 opened this issue Jul 29, 2021 · 12 comments
Open

MakeInstall.bat doesn't show ANY devices #236

Otus9051 opened this issue Jul 29, 2021 · 12 comments

Comments

@Otus9051
Copy link

I am trying to use Clover and use makeinstall.bat for install the OS image to my usb. Problem is nothing shows up. I have also tried manually using makeinstall.py and using administrator privileges (even though it asks for one every time). Nothing happened. I deleted all partitions from my usb, tried replugging it, tried NTFS and Fat32. Nothing shows up. Also I did try the Show All disks option which still didn't do anything,

@Otus9051
Copy link
Author

Commit Number 4083ca20785d96ef26eecac89c1c9e37532beb44 seems more broken as it doesn't even open. FYI I am using Python 3.9

@brendoncdrew
Copy link

brendoncdrew commented Oct 29, 2021

You ever figure out how to fix this???

I seem to be having the same issue.....

@Otus9051
Copy link
Author

Never.

@brendoncdrew
Copy link

Damn

@cutie-lyta
Copy link

cutie-lyta commented Nov 12, 2021

The reason it is broken, on my end at least, is the removal of wmic.exe on windows 11, and I think later version of 10
It might still work on 8.1 and early 10 version, didn't test tho
I am trying to switch to the powershell Get-WMIObject command, but I don't know how to use powershell so I have no luck unfortunately

But at least I know where it's from, if we didn't already

@The-Synthax
Copy link

Seems that this is still unusable on Windows 11.

@Otus9051
Copy link
Author

Fixed on mine tho

@The-Synthax
Copy link

Fixed on mine tho

Weird. Any idea what fixed it?

@Otus9051
Copy link
Author

nope. no idea. actually, try installing the media feature pack maybe that helped it?

@wilkergrcv
Copy link

If you are using an external hard drive instead of a flash drive, change this line in the MakeInstall.py file.

By default it will be like this:

def get_disks_of_type(self, disk_list, disk_type=(0,2)):

with this configuration makeinstall will only show removable and unknown devices

now just change that same line with a 3 looking like this

def get_disks_of_type(self, disk_list, disk_type=(0,2,3)):

save the file and run MakeInstall.bat again and be happy.

@RavHilton
Copy link

Same issue here - no drives are shown (Win 11, latest public build, latest public updates, Python 3.11.1, x64) and the addition of disk_type "3" as suggested by https://github.com/wilkergrcv makes no difference at all. Yes, already running elevated as admin...

Even after using option "D", all I see is as follows:

#######################################################

Potential Removable Media
#######################################################

!WARNING! This list includes ALL disk types.
!WARNING! Be ABSOLUTELY sure before selecting
!WARNING! a disk!

Q. Quit

Usage:

@KuusamoMart
Copy link

See issue 179 where I have carried out some investigations of the diskwin script and why it doesn't work correctly under Windows 11 and later releases of Windows 10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants