Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No resources returned in v1.3.4 #93

Closed
d-expired opened this issue Sep 14, 2020 · 5 comments · Fixed by #98
Closed

No resources returned in v1.3.4 #93

d-expired opened this issue Sep 14, 2020 · 5 comments · Fixed by #98
Assignees

Comments

@d-expired
Copy link

d-expired commented Sep 14, 2020

Describe the bug
No resources are being returned in the latest version of the krew plugin.

To Reproduce
Steps to reproduce the behavior:

  1. kubectl get-all -n bar
  2. See error:
    DEBU[0000] Set log-level to debug DEBU[0001] Resources to fetch: [] DEBU[0001] Initial fetchResourcesBulk done (0s) DEBU[0001] Fetch resources incrementally DEBU[0001] Requests done (elapsed 0s) WARN[0001] No resources found, are you authorized? Try to narrow the scope with --namespace. FATA[0001] no resources found

Expected behavior
I expected too see the same resources I could in v1.3.2

Screenshots
image

Desktop (please complete the following information):

  • output of ketall version --full:

ketall: v1.3.4
platform: darwin/amd64
git commit: 071f5c7
build date: 2020-09-04T23:14:49Z
go version: go1.15
compiler: gc

  • OS: MacOS
  • Browser: Firefox
  • Version 1.3.4

Additional context
Exact same command and kubectl version worked fine for version 1.3.2, seems to be a bug.

@corneliusweig
Copy link
Owner

Can you also share your kubernetes version? kubectl version
And are you running a standard k8s distribution?

I bumped the k8s version in 1.3.3 and maybe that creates some incompatibilities.

@d-expired
Copy link
Author

d-expired commented Sep 15, 2020

Client Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.6", GitCommit:"d32e40e20d167e103faf894261614c5b45c44198", GitTreeState:"clean", BuildDate:"2020-05-20T13:16:24Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"darwin/amd64"}

Server Version: version.Info{Major:"1", Minor:"17+", GitVersion:"v1.17.9-eks-4c6976", GitCommit:"4c6976793196d70bc5cd29d56ce5440c9473648e", GitTreeState:"clean", BuildDate:"2020-07-17T18:46:04Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"linux/amd64"}

@busser
Copy link
Contributor

busser commented Sep 22, 2020

v1.3.3 works for me but not v1.3.4.

I believe a previous commit broke ketall though: 93a2c9f

Specifically, all booleans in the scope logic were flipped except this one: 93a2c9f#diff-2c846caea57b2b1d6e49c6417f337625R214

I've opened a pull request with a fix: #98

@d-expired
Copy link
Author

Thanks, latest version is now working for me 👍

@corneliusweig
Copy link
Owner

The praise goes to @busser who looked into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants