Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

line-height changed? #30

Closed
shabahengam opened this issue Aug 31, 2020 · 9 comments
Closed

line-height changed? #30

shabahengam opened this issue Aug 31, 2020 · 9 comments
Labels
fixed? might be fixed, needs to be checked by issue author stale

Comments

@shabahengam
Copy link

please look at the picture.
Left v0.010 ... Right v0.011
https://0x0.st/iExn.png
6 line less is a big change.don't you think?

OS: Linux
Terminal: rxvt-unicode
Editor: Neovim
Font: JuliaMono Medium,Size 10

@cormullion
Copy link
Owner

Indeed - i’m trying to find a good compromise between good line spacing and people losing the tops of accents - see previous issue. 😂

Next release might be adjusted back a bit. You can stay with v0.010 perhaps?

@shabahengam
Copy link
Author

You can stay with v0.010 perhaps?

Yep,I will stay with v0.010.Thank you for creating this font. 👍

@cormullion
Copy link
Owner

By the way, do you have a separate line-spacing option on your terminal?

@shabahengam
Copy link
Author

URxvt.lineSpace: 0 is set in .Xresource.
PS: I had this issue with agave font, maybe this issue can help?

@cormullion
Copy link
Owner

I think most fonts have to compromise, I'm trying to find settings that works for people who use accented characters and people who want more lines to a screen. ;) I think a quality terminal application should allow you to make the choice you want: here's the MacOS terminal with 0.8 (left) and 1..0 (right) linespacing. The font shouldn't be having to do this job for you...

Screenshot 2020-09-01 at 15 14 49

In the next release (today or tomorrow) I'm going to compromise between the settings of release v0.10 and v0.11. If this doesn't work for you, I'll be disappointed 😄) - and I'd suggest you try a more powerful terminal app that gives more customization...

@shabahengam
Copy link
Author

v0.012 is better.now I have 40 lines on my screen(in neovim).thank you 👍

@cormullion
Copy link
Owner

Cool!

@cormullion cormullion added the fixed? might be fixed, needs to be checked by issue author label Sep 5, 2020
@stale
Copy link

stale bot commented Oct 18, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions!

@stale stale bot added the stale label Oct 18, 2020
@shabahengam
Copy link
Author

OK, I close the issue because I think it get fixed.Thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed? might be fixed, needs to be checked by issue author stale
Projects
None yet
Development

No branches or pull requests

2 participants