Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.0] Make data_offset relative to the data section of the file #142

Open
bchess opened this issue Jun 27, 2024 · 0 comments · May be fixed by #170
Open

[3.0] Make data_offset relative to the data section of the file #142

bchess opened this issue Jun 27, 2024 · 0 comments · May be fixed by #170
Assignees
@Eta0
Labels
schema-change label for 3.0-dev work that involves schema changes serialization
Milestone
3.0

Comments

@bchess
Copy link
Contributor

bchess commented Jun 27, 2024

Eta0 last week
This should be relative to the data section of the file to make headers less dependent on the length of the metadata section, which could still be indeterminate when this would otherwise be ready to commit.
@bchess bchess added this to the 3.0 milestone Jun 27, 2024
@bchess bchess mentioned this issue Jun 27, 2024
Merged
@bchess bchess added serialization schema-change label for 3.0-dev work that involves schema changes labels Jun 27, 2024
@Eta0 Eta0 self-assigned this Jul 3, 2024
@Eta0 Eta0 linked a pull request Jul 18, 2024 that will close this issue
Open
@Eta0 Eta0 linked a pull request Jul 18, 2024 that will close this issue
feat(serialization): Store relative offsets for tensor data and headers #170
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Eta0 Eta0

Labels
schema-change label for 3.0-dev work that involves schema changes serialization
Projects
None yet
Milestone
3.0
Development

Successfully merging a pull request may close this issue.

feat(serialization): Store relative offsets for tensor data and headers coreweave/tensorizer
2 participants
@bchess @Eta0