ci: add testing using 1.17/1.18 #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
huh...i thought i tested this on the affected versions...back to the drawing board |
Go 1.17 introduced the new build constraint format[1] and `gofmt` now complains if the new constraint format isn't present when the old format is found. [1] https://go.googlesource.com/proposal/+/master/design/draft-gobuild.md
10 tasks
|
Thanks for the PR! As we have a separate job for testing the minimum Go toolchain, old intermediate versions can be skipped. I added a commit on your branch to drop them. LGTM! |
lucab
approved these changes
Apr 1, 2022
lucab
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expands the matrix of Go versions that are being tested with each PR.
In order to support 1.17+, the build constraints had to be updated to make
gofmthappy.