freelist: read all free pages on count overflow #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oops... lgtm |
|
looks like something else is going on around this, going to add some stricter checking |
heyitsanthony
force-pushed
the
skip-freelist-overflow
branch
from
2911a17 to
03f5e16
Compare
heyitsanthony
changed the title
added 2 commits
August 8, 2017 23:37
Confirm that the number of freed pages exceeds the overflow count, then check that reopening gives the same number of free pages.
count is not shifted up by start index when taking subslice of free list, dropping the last entry in the list.
|
turns out there's a free page leak on read back /cc @benbjohnson |
|
Do you have a test that can reproduce the issue? |
|
@benbjohnson yes, close/reopen after the freelist overflow test; db checking catches the leaked page as unreachable/unfreed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
count is not shifted up by start index when taking subslice of free
list, dropping the last entry in the list.