core,core/vm: remove EvmPool after the rework of EVM constructor

After the rework done at ethereum/go-ethereum#30745 we had to remove the EvmPool as the PR aims on using a single EVM for the whole block execution.

The EvmPool was creating a race condition on miner tests

Author: ziogaschr

core/state_processor.go

@@ -240,12 +240,6 @@ func ApplyTransaction(config *params.ChainConfig, evm *vm.EVM, gp *GasPool, stat
 	if err != nil {
 		return nil, err
 	}
-	// TODO(CZ): do we need this?
-	defer func() {
-		ite := evm.Interpreter()
-		vm.EVMInterpreterPool.Put(ite)
-		vm.EvmPool.Put(evm)
-	}()
 	return ApplyTransactionWithEVM(msg, config, gp, statedb, header.Number, header.Hash(), tx, usedGas, evm, receiptProcessors...)
 }
 

core/vm/evm.go

@@ -19,7 +19,6 @@ package vm
 import (
 	"errors"
 	"math/big"
-	"sync"
 	"sync/atomic"
 
 	"github.com/ethereum/go-ethereum/common"
@@ -30,12 +29,6 @@ import (
 	"github.com/holiman/uint256"
 )
 
-var EvmPool = sync.Pool{
-	New: func() interface{} {
-		return &EVM{}
-	},
-}
-
 type (
 	// CanTransferFunc is the signature of a transfer guard function
 	CanTransferFunc func(StateDB, common.Address, *uint256.Int) bool
@@ -124,17 +117,13 @@ type EVM struct {
 // NewEVM returns a new EVM. The returned EVM is not thread safe and should
 // only ever be used *once*.
 func NewEVM(blockCtx BlockContext, statedb StateDB, chainConfig *params.ChainConfig, config Config) *EVM {
-	evm := EvmPool.Get().(*EVM)
-	evm.Context = blockCtx
-	evm.StateDB = statedb
-	evm.Config = config
-	evm.chainConfig = chainConfig
-	evm.chainRules = chainConfig.Rules(blockCtx.BlockNumber, blockCtx.Random != nil, blockCtx.Time)
-
-	evm.abort.Store(false)
-	evm.callGasTemp = 0
-	evm.depth = 0
-
+	evm := &EVM{
+		Context:     blockCtx,
+		StateDB:     statedb,
+		Config:      config,
+		chainConfig: chainConfig,
+		chainRules:  chainConfig.Rules(blockCtx.BlockNumber, blockCtx.Random != nil, blockCtx.Time),
+	}
 	evm.precompiles = activePrecompiledContracts(evm.chainRules)
 	evm.interpreter = NewEVMInterpreter(evm)