Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling jobs only in CI. #62

Open
Zimmi48 opened this issue Sep 2, 2021 · 6 comments
Open

Disabling jobs only in CI. #62

Zimmi48 opened this issue Sep 2, 2021 · 6 comments

Comments

@Zimmi48
Copy link
Member

Zimmi48 commented Sep 2, 2021

In coq-community/paramcoq#75, I had to put coqPackages.mathcomp.job = false; because I had also put coqPackages.mathcomp.override.version = "master"; but there was no reason to have a CI job building the full mathcomp.

In jwiegley/category-theory#21, since no Cachix was set, I wanted to avoid the inefficiency of having dependencies built in separate jobs (only to be rebuilt in the main job). Therefore, I had to put a number of job = false; (more for the "dev" bundles than for the others). In the case of Coq, the unwanted consequence is that Coq is silently skipped when we try to build it, and it is only actually built later on, while trying to build ssreflect: https://github.com/Zimmi48/category-theory/runs/3493747463?check_suite_focus=true#step:10:9

There should be a way of excluding a job from CI without making nix-build --job a no-op.

@Zimmi48
Copy link
Member Author

Zimmi48 commented Sep 17, 2021

Related to this, something that I still didn't understand is why some jobs marked as job = false; are still showing up in the GitHub Actions generated for this repo (e.g. coq-shell, and heq and mathcomp-bigenough in the master workflow).

@CohenCyril CohenCyril pinned this issue Sep 22, 2021
@CohenCyril CohenCyril unpinned this issue Sep 22, 2021
@CohenCyril
Copy link
Collaborator

@Zimmi48

I had to put coqPackages.mathcomp.job = false; because I had also put coqPackages.mathcomp.override.version = "master";

I do not understand this sentence. Why put job = false?

@Zimmi48
Copy link
Member Author

Zimmi48 commented Sep 22, 2021

Because otherwise the generated workflow contained a job building mathcomp (full) even though I only needed one for mathcomp-ssreflect IIRC.

@CohenCyril
Copy link
Collaborator

Related to this, something that I still didn't understand is why some jobs marked as job = false; are still showing up in the GitHub Actions generated for this repo (e.g. coq-shell, and heq and mathcomp-bigenough in the master workflow).

This was a bug, I fixed it in #75, why exclude coq-shell, bigenough and heq though?

@Zimmi48
Copy link
Member Author

Zimmi48 commented Oct 30, 2021

Coq-shell, I don't know, but the rest of them are not really expected to be compatible with Coq master, are they?

@CohenCyril
Copy link
Collaborator

Coq-shell, I don't know, but the rest of them are not really expected to be compatible with Coq master, are they?

I see I misread, I thought all of them were suppressed for released versions.
I do not see why we would remove coq-shell I will keep it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants