Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to add a "new" theorem? #38

Open
Boutry opened this issue Mar 18, 2024 · 1 comment
Open

How to add a "new" theorem? #38

Boutry opened this issue Mar 18, 2024 · 1 comment

Comments

@Boutry
Copy link

Boutry commented Mar 18, 2024

I see that there is a html file that seems to match the page. But there are also some .v. To add an already formalized theorem that belongs to the list, namely #12: The Independence of the Parallel Postulate, should I create a PR with just the added part for the html or also the necessary .v files allowing to verify this?

@jmadiot
Copy link
Collaborator

jmadiot commented Mar 19, 2024

I added some instructions in the README (in particular do not edit the html but the statements.yml file instead).

I'm not sure I understand the situation exactly, but if the statement is already in GeoCoq then only a link to its location is necessary. Otherwise, if there is a single self-contained file, then adding it here is fine. However if the .v files depend on GeoCoq, adding them here would imply extra complexity, dependencies and CI build time, so it might be best to add them somewhere else. Maybe in GeoCoq itself?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants