Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stickler on windows issues #52

Open
xrmb opened this issue Oct 24, 2017 · 1 comment
Open

stickler on windows issues #52

xrmb opened this issue Oct 24, 2017 · 1 comment
Assignees

Comments

@xrmb
Copy link

xrmb commented Oct 24, 2017

I'm not sure if stickler is supposed to run on windows or not. It comes with .cmd wrappers for the stickler and stickler-server commands, but that could just be auto-gen code.

Anyway, after patching some binmodes into local.rb
tempfile = Tempfile.new( "uploaded-gem.", temp_dir )
tempfile.binmode
tempfile.write( io.read )

and

def install_gem( spec, io )
  File.open( full_path_to_gem( spec ) , "w+" ) do |of|
    of.binmode
    io.each do |str|
      of.write( str )
    end
  end
end

and "deactivating" syslog in the logable.rb it seems to work.

But the question is, should it...?

@copiousfreetime copiousfreetime self-assigned this Feb 1, 2018
@copiousfreetime
Copy link
Owner

@xrmb Yes, the .cmd wrappers are autogen by rubygems on installation. And those are totally reasonable suggestions. Stickler is long overdue for an update especially since it doesn't support the bundler api. so that may be a project coming up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants