What sort of engagement would maintainers like on pull requests raised? #1981
Replies: 1 comment 1 reply
-
Yep, completely agree. For me personally, it's generally fine to ping me on my own projects. Here however I'd prefer not being mentioned directly if I didn't already participate in an issue/PR. One could probably mention @copier-org/maintainers when an issue/PR didn't move forward in a couple weeks, just to make sure we didn't forget about it. I think we should groom the backlog of PRs, as IMO there's nothing worse than letting them go stale. It makes the PR tab and our heads noisy. If nobody can pick a PR up, we should close it 🤷 For your issue and PR specifically, they look legit and reasonable, I simply skipped them, sorry 😄 Thanks for the very kind reminder, and for your incredible patience, I'll try to find some time to replicate the issue and review the changes 🙂 |
Beta Was this translation helpful? Give feedback.
-
Hey! I've read the CONTRIBUTING.md and there doesn't seem to be any guidance on communication beyond raising issues and pull requests
For instance, is the expectation that maintainers actively monitor new issues or pull requests, but one should tag a maintainer on later followups etc, or just be patient and people will get to things when/if they do
Conscious that this is open source and people have limited time, so I don't have an expectation that things will be happen quickly or regularly necessarily. It's just a bit difficult to know when/how to follow up in a way that's respectful of the wishes of the maintainers but doesn't delay things unnecessarily if it's just an oversight
The CONTRIBUTING.md section on "Pull Request Guidelines" does mention to "Check that all checks pass on GitHub CI." but it's unclear if this should be on personal forks, or in the pull request to this copier repo (which requires approval from a maintainer)
Example context: I've raised an issue, and a corresponding fix in a pull request a while back (#1892) and I'm wondering if someone will get to triggering the tests and reviewing it eventually, it's just low-priority, or if it's been missed and could benefit from a bump (given there has been a new release that has gone out since it's been raised)
I'm interested in making future contributions so I am looking to understand for future reference. Thanks!
Beta Was this translation helpful? Give feedback.
All reactions