Skip to content

Commit 9a2fd04

Browse files
authored
fix: don't lie about updated files
Updating involves some low-level git-fu. This can cause unpredicted files to get updated, and the report to the user sometimes is fake. It'd be great to tell the truth, but for now at least let's just not lie. Fix #943. Co-authored-by: Sigurd Spieckermann <[email protected]>
1 parent 9fc58b8 commit 9a2fd04

File tree

1 file changed

+10
-1
lines changed

1 file changed

+10
-1
lines changed

copier/main.py

+10-1
Original file line numberDiff line numberDiff line change
@@ -853,7 +853,16 @@ def _apply_update(self):
853853
with suppress(AttributeError):
854854
del self.subproject.last_answers
855855
# Do a normal update in final destination
856-
self.run_copy()
856+
current_worker = replace(
857+
self,
858+
# Files can change due to the historical diff, and those
859+
# changes are not detected in this process, so it's better to
860+
# say nothing than lie.
861+
# TODO
862+
quiet=True,
863+
)
864+
current_worker.run_copy()
865+
self.answers = current_worker.answers
857866
# Render with the same answers in an empty dir to avoid pollution
858867
new_worker = replace(
859868
self,

0 commit comments

Comments
 (0)