Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URI-encode depreciated #87

Open
ehcorn opened this issue Nov 20, 2022 · 2 comments
Open

URI-encode depreciated #87

ehcorn opened this issue Nov 20, 2022 · 2 comments

Comments

@ehcorn
Copy link

ehcorn commented Nov 20, 2022

get the following when running shards build:

Dependencies are satisfied
Building: irs
In src/search/spotify.cr:261:16

 261 | return URI.encode(query.rchop("+"))
                  ^-----
Warning: Deprecated URI.encode. Use `.encode_path` instead.

In /opt/homebrew/Cellar/crystal/1.6.2/share/crystal/src/uri/encoding.cr:123:25

 123 | String.build { |io| encode(string, io, space_to_plus: space_to_plus) }
                           ^-----
Warning: Deprecated URI.encode:space_to_plus. Use `.encode_path` instead.

A total of 2 warnings were found.

system is an M1 macbook air, crystal is installed through homebrew and curerntly version 1.6.2, here's the info on the brew version of crystal for my system:

==> crystal: stable 1.6.2 (bottled), HEAD
Fast and statically typed, compiled language with Ruby-like syntax
https://crystal-lang.org/
/opt/homebrew/Cellar/crystal/1.6.2 (1,349 files, 21.9MB) *
  Poured from bottle on 2022-11-20 at 11:56:38
From: https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/crystal.rb
License: Apache-2.0
==> Dependencies
Required: bdw-gc ✔, gmp ✔, libevent ✔, libyaml ✔, llvm@14 ✔, [email protected] ✔, pcre ✔, pkg-config ✔
==> Options
--HEAD
	Install HEAD version
==> Caveats
zsh completions have been installed to:
  /opt/homebrew/share/zsh/site-functions
@samsammerson
Copy link

Getting the same issue on Fedora

@hb1796
Copy link

hb1796 commented Nov 27, 2024

getting the same issue on arch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants