Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Incorrect docker-compose message when not able to connect with GitHub #2563

Closed
matpratta opened this issue Jun 15, 2024 · 5 comments · Fixed by #4246
Closed

[Bug]: Incorrect docker-compose message when not able to connect with GitHub #2563

matpratta opened this issue Jun 15, 2024 · 5 comments · Fixed by #4246

Comments

@matpratta
Copy link
Contributor

matpratta commented Jun 15, 2024

Description

When creating a new resource from GitHub (in my case, I used the deploy key method), if you happen to use the incorrect address (for example, the repository's HTTP address) it will return an error message saying the docker-compose.yaml file was not found instead of telling the repository address is incorrect.

Fixes by using the SSH address instead, but not very obvious at first glance.

Minimal Reproduction (if possible, example repository)

  1. Create a new resource from GitHub, if possible, of a private repository using a deploy key;
  2. Make sure you use the Docker Compose option;
  3. Use the repository's HTTP address instead of SSH;
  4. An error message telling the docker-compose.yaml file not being found will show up, instead of telling Git address is incorrect;

Exception or Error

No response

Version

v4.0.0-beta.297

@komali2
Copy link

komali2 commented Jul 23, 2024

I may be having this issue, the project can't find my docker-compose file but I'm 100% getting the filename correct.

@matpratta
Copy link
Contributor Author

@komali2 there's a chance you might have added the HTTPS address instead of SSH, try changing it to see if it helps. The PRs should've fixed it, but I don't think they got reviewed/merged yet.

@komali2
Copy link

komali2 commented Sep 20, 2024

@matpratta thanks for the shout. I updated to v4.0.0-beta.341 and confirmed the repo source is using ssh (I also tested https cause why not)

2024-09-20-151624_1105x378_scrot

still getting the error :(

@matpratta
Copy link
Contributor Author

@komali2 I think this one wasn't merged yet, maybe @andrasbacsai has any feedback if I need to do any changes first?

@andrasbacsai
Copy link
Member

This will be fixed in the next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants