Skip to content

Commit 79f25d3

Browse files
authored
Merge pull request #93 from coord-e/mysql-8.0
Run tests with mysql:8.0 and drop support for Ruby < 3.0
2 parents 8da0c07 + b69e38d commit 79f25d3

File tree

3 files changed

+7
-9
lines changed

3 files changed

+7
-9
lines changed

.github/workflows/ci.yml

+4-3
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,14 @@ jobs:
1111
fail-fast: false
1212
matrix:
1313
ruby:
14-
- '2.6'
15-
- '2.7'
1614
- '3.0'
15+
- '3.1'
16+
- '3.2'
17+
- '3.3'
1718
name: Run test with Ruby ${{ matrix.ruby }}
1819
services:
1920
mysql:
20-
image: mysql:5.7
21+
image: mysql:8.0
2122
env:
2223
MYSQL_ROOT_PASSWORD: barbeque_root
2324
MYSQL_USER: barbeque

CHANGELOG.md

+2
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
- Update Rails to 6.1
44
- For Zeitwerk, Barbeque::SNSSubscription and Barbeque::SNSSubscriptionService are renamed to Barbeque::SnsSubscription and Barbeque::SnsSubscriptionService respectively
55
- Support Ruby 3.0
6+
- Drop support for Ruby < 3.0
7+
- Drop support for MySQL 5.7
68

79
## v2.8.0 (2021-12-23)
810
### New features

spec/barbeque/executor_spec.rb

+1-6
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,7 @@
1212
let(:barbeque_yml) { 'barbeque' }
1313

1414
it 'initializes a configured executor' do
15-
if Gem::Version.new(RUBY_VERSION) < Gem::Version.new('2.7.0')
16-
# Ruby < 2.7 isn't ready for keyword arguments
17-
expect(Barbeque::Executor::Docker).to receive(:new).with({})
18-
else
19-
expect(Barbeque::Executor::Docker).to receive(:new).with(no_args)
20-
end
15+
expect(Barbeque::Executor::Docker).to receive(:new).with(no_args)
2116
Barbeque::Executor.create
2217
end
2318
end

0 commit comments

Comments
 (0)